[
https://issues.apache.org/jira/browse/BAHIR-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371955#comment-15371955
]
ASF subversion and git services commented on BAHIR-23:
------------------------------------------------------
Commit d6770f833ec723f24ea452c11fd102624d12c3f2 in bahir's branch
refs/heads/master from [~ckadner]
[ https://git-wip-us.apache.org/repos/asf?p=bahir.git;h=d6770f8 ]
[BAHIR-23] Build should fail on Checkstyle violations
Currently the maven build is configured to:
- fail for code style violations in Scala files
- succeed despite code style violations in Java files
- exclude Scala test sources (and examples) from code style checks
- include Java test sources (and examples) in code style checks
This changes the maven build configuration to
- fail for code style violations in both Scala and Java sources
- include test sources (and examples) in style checks for both
Scala and Java sources
Additionally cleaning up unsupported checkstyle configuration
elements (apparently copy-and-pasted from scalastyle configuration)
> Build should fail on Checkstyle violation
> -----------------------------------------
>
> Key: BAHIR-23
> URL: https://issues.apache.org/jira/browse/BAHIR-23
> Project: Bahir
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.0.0
> Reporter: Christian Kadner
> Assignee: Christian Kadner
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Currently the maven build will fail for code style violations in Scala files
> but the build will succeed regardless of code style violations in Java files.
> {code:xml}
> <plugin>
> ...
> <artifactId>scalastyle-maven-plugin</artifactId>
> ...
> <configuration>
> ...
> <failOnViolation>true</failOnViolation>
> ...
> </configuration>
> ...
> </plugin>
> <plugin>
> ...
> <artifactId>maven-checkstyle-plugin</artifactId>
> ...
> <configuration>
> ...
> <failOnViolation>false</failOnViolation>
> ...
> </configuration>
> ...
> </plugin>
> {code}
> As a consequence potential problems in the Java code may not get noticed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
