Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/10#discussion_r71425516
  
    --- Diff: streaming-mqtt/python-tests/tests.py ---
    @@ -0,0 +1,213 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +import sys
    +import time
    +import random
    +
    +if sys.version_info[:2] <= (2, 6):
    +    try:
    +        import unittest2 as unittest
    +    except ImportError:
    +        sys.stderr.write('Please install unittest2 to test with Python 2.6 
or earlier')
    +        sys.exit(1)
    +else:
    +    import unittest
    +
    +from pyspark.context import SparkConf, SparkContext, RDD
    +from pyspark.streaming.context import StreamingContext
    +from mqtt import MQTTUtils
    +
    +
    +class PySparkStreamingTestCase(unittest.TestCase):
    --- End diff --
    
    You _could_ consider using the PySpark base test case here instead of 
copying it - might break on update but could be good to reduce copypasta.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to