[
https://issues.apache.org/jira/browse/BAHIR-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384874#comment-15384874
]
ASF GitHub Bot commented on BAHIR-24:
-------------------------------------
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/bahir/pull/10#discussion_r71425516
--- Diff: streaming-mqtt/python-tests/tests.py ---
@@ -0,0 +1,213 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import sys
+import time
+import random
+
+if sys.version_info[:2] <= (2, 6):
+ try:
+ import unittest2 as unittest
+ except ImportError:
+ sys.stderr.write('Please install unittest2 to test with Python 2.6
or earlier')
+ sys.exit(1)
+else:
+ import unittest
+
+from pyspark.context import SparkConf, SparkContext, RDD
+from pyspark.streaming.context import StreamingContext
+from mqtt import MQTTUtils
+
+
+class PySparkStreamingTestCase(unittest.TestCase):
--- End diff --
You _could_ consider using the PySpark base test case here instead of
copying it - might break on update but could be good to reduce copypasta.
> Fix MQTT Python code
> --------------------
>
> Key: BAHIR-24
> URL: https://issues.apache.org/jira/browse/BAHIR-24
> Project: Bahir
> Issue Type: Bug
> Components: Spark Streaming Connectors
> Affects Versions: 2.0.0
> Reporter: Christian Kadner
> Assignee: Christian Kadner
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> When the Bahir project was created from Spark revision {{8301fadd8}} the
> Python code (incl. examples) were not updated with respect to the modified
> project structure and test cases were left out from the import.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
