[
https://issues.apache.org/jira/browse/BAHIR-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672143#comment-15672143
]
ASF GitHub Bot commented on BAHIR-75:
-------------------------------------
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/bahir/pull/27#discussion_r88360001
--- Diff: pom.xml ---
@@ -446,6 +447,7 @@
<exclude>.classpath</exclude>
<exclude>.project</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
+
<exclude>**/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister</exclude>
--- End diff --
@lresende even though
[java.util.ServiceLoader](http://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html)
ignores `#`-comment lines I did not see any examples of it being used in
DataSourceRegister files of other projects — i.e. Spark does not include
license comments in its 3 DataSourceRegister service provider configuration
files. What's wrong with excluding it from the RAT license checks?
> Initial Code Delivery
> ---------------------
>
> Key: BAHIR-75
> URL: https://issues.apache.org/jira/browse/BAHIR-75
> Project: Bahir
> Issue Type: Sub-task
> Components: Spark SQL Data Sources
> Reporter: Sourav Mazumder
> Original Estimate: 504h
> Remaining Estimate: 504h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
