ASF GitHub Bot commented on BAHIR-85:

Github user rmetzger commented on the issue:

    I don't fully understand the purpose of this change. I propose to close the 
pull request and discuss the implementation in the JIRA first before opening 
another PR.

> Redis Sink Connector should allow update of command without reinstatiation    
> ---------------------------------------------------------------------------
>                 Key: BAHIR-85
>                 URL: https://issues.apache.org/jira/browse/BAHIR-85
>             Project: Bahir
>          Issue Type: Improvement
>          Components: Flink Streaming Connectors
>            Reporter: Atharva Inamdar
> ref: FLINK-5478
> `getCommandDescription()` gets called when RedisSink is instantiated. This 
> happens only once and thus doesn't allow the command to be updated during run 
> time.
> Use Case:
> As a dev I want to store some data by day. So each key will have some date 
> specified. this will change over course of time. for example: 
> `counts_for_1484265600000` for 2017-01-13. This is not limited to any 
> particular command.
> connector: 
> https://github.com/apache/bahir-flink/blob/master/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java#L114
> I wish `getCommandDescription()` could be called in `invoke()` so that the 
> key can be updated without having to restart.

This message was sent by Atlassian JIRA

Reply via email to