[ 
https://issues.apache.org/jira/browse/BAHIR-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101223#comment-16101223
 ] 

ASF GitHub Bot commented on BAHIR-122:
--------------------------------------

Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/48
  
    thanks @ire7715 -- I have a few remarks regarding your latest comment:
    
    ---
    
    > Don't know if the force push would bother you when reviewing
    
    Thanks for not force-pushing :+1: -- It's preferable to have multiple 
commits in response to PR review comments and change requests. This makes it 
much easier to come back later to see how code changes came about. Bahir 
committers will squash all commits when merging Pull Requests.
    
    So, please push another "normal" commit with your latest changes. 
    
    ---
    
    > `SparkGCPCredentialsBuilderSuite` ... ignores the test cases if the key 
files or email account [environment variables] are not set (or file doesn't 
exist) and shows the hint message
    
    I agree mostly. We should ignore the test cases if env variables are not 
set. However, if the environment variables **are set** and the key file **path 
is invalid** then that should be an **error**. Otherwise we may not catch 
problems if there are changes in the Jenkins CI server.
    
    Could you generate a set of (permanent) key files which we can integrate 
into our Jenkins PR builder?


> [PubSub] Make "ServiceAccountCredentials" really broadcastable
> --------------------------------------------------------------
>
>                 Key: BAHIR-122
>                 URL: https://issues.apache.org/jira/browse/BAHIR-122
>             Project: Bahir
>          Issue Type: Improvement
>          Components: Spark Streaming Connectors
>            Reporter: Ire Sun
>
> The origin implementation broadcast the key file path to Spark cluster, then 
> the executor read key file with the broadcasted path. Which is absurd, if you 
> are using a shared Spark cluster in a group/company, you certainly not want 
> to (and have no right to) put your key file on each instance of the cluster.
> If you store the key file on driver node and submit your job to a remote 
> cluster. You would get the following warning:
> {{WARN ReceiverTracker: Error reported by receiver for stream 0: Failed to 
> pull messages - java.io.FileNotFoundException}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to