[ 
https://issues.apache.org/jira/browse/BAHIR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285203#comment-16285203
 ] 

ASF GitHub Bot commented on BAHIR-152:
--------------------------------------

Github user ApacheBahir commented on the issue:

    https://github.com/apache/bahir/pull/58
  
    :white_check_mark: Build successful
     



> License header not enforced for Java sources
> --------------------------------------------
>
>                 Key: BAHIR-152
>                 URL: https://issues.apache.org/jira/browse/BAHIR-152
>             Project: Bahir
>          Issue Type: Bug
>          Components: Build, Spark SQL Data Sources, Spark Streaming 
> Connectors, Spark Structured Streaming Connectors
>    Affects Versions: Not Applicable
>            Reporter: Christian Kadner
>            Assignee: Christian Kadner
>             Fix For: Spark-2.2.1, Spark-2.3
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In any Java source file add this line on top of the license header:
> {code}
> /*
>  * Copyright (c) 2017 ACME. All rights reserved.
>  * <p>
> {code}
> then run {{mvn clean verify}} and see the build succeed.
> Neither of the following maven goals complains either:
>  - {{mvn apache-rat:check}}
>  - {{mvn checkstyle:check}}
> Adding a similar copyright statement to any of the Scala sources will fail 
> the {{HeaderMatchesChecker}} rule in our {{scalastyle}} checks.
> I am not sure why the 
> [RAT|http://creadur.apache.org/rat/apache-rat-plugin/usage.html] checks allow 
> this to pass, but I will add a similar {{Header}} verification to our 
> {{checkstyle}} configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to