[ 
https://issues.apache.org/jira/browse/BAHIR-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311318#comment-16311318
 ] 

ASF GitHub Bot commented on BAHIR-137:
--------------------------------------

Github user ricellis commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/60#discussion_r159648190
  
    --- Diff: 
sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreConfigManager.scala
 ---
    @@ -35,6 +35,7 @@ object JsonStoreConfigManager {
       private val CLOUDANT_PASSWORD_CONFIG = "cloudant.password"
       private val CLOUDANT_PROTOCOL_CONFIG = "cloudant.protocol"
       private val CLOUDANT_API_ENDPOINT = "cloudant.endpoint"
    +  private val CLOUDANT_STREAMING_BATCH_INTERVAL = "cloudant.batchInterval"
       private val STORAGE_LEVEL_FOR_CHANGES_INDEX = "cloudant.storageLevel"
    --- End diff --
    
    This still says `cloudant.storageLevel` but the documentation was changed 
to `storageLevel`, shouldn't they be the same?
      


> Load performance improvements for _changes API in sql-cloudant
> --------------------------------------------------------------
>
>                 Key: BAHIR-137
>                 URL: https://issues.apache.org/jira/browse/BAHIR-137
>             Project: Bahir
>          Issue Type: Improvement
>    Affects Versions: Spark-2.2.0
>            Reporter: Esteban Laver
>            Assignee: Esteban Laver
>
> Items for improving _changes feed load:
> - Make Spark streaming batch interval visible to the user for tuning based on 
> type/size of document and number of docs in database
> - Merge BAHIR-128: Improve stability of _changes receiver
> - Merge BAHIR-154: refactor sql-cloudant to use java-cloudant library



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to