[ https://issues.apache.org/jira/browse/BAHIR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313234#comment-16313234 ]
ASF GitHub Bot commented on BAHIR-154: -------------------------------------- Github user ricellis commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r159889644 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreRDD.scala --- @@ -174,7 +178,11 @@ class JsonStoreRDD(sc: SparkContext, config: CloudantConfig) implicit val postData : String = { if (queryUsed) { - Json.stringify(Json.obj("selector" -> selector, "limit" -> 1)) + val jsonSelector = new JsonObject + jsonSelector.addProperty("selector", selector.toString) + jsonSelector.addProperty("limit", 1) + jsonSelector.toString + // Json.stringify(Json.obj("selector" -> selector, "limit" -> 1)) --- End diff -- remove > Refactor sql-cloudant to use Cloudant's java-cloudant features > -------------------------------------------------------------- > > Key: BAHIR-154 > URL: https://issues.apache.org/jira/browse/BAHIR-154 > Project: Bahir > Issue Type: Improvement > Affects Versions: Spark-2.2.0 > Reporter: Esteban Laver > Assignee: Esteban Laver > > Cloudant's java-cloudant library (which is currently used for testing) > contains several features that sql-cloudant can benefit from: > - HTTP 429 backoff > - View builder API to potentially simplify loading for _all_docs/views > - Improved exception handling when executing HTTP requests > - Future support for IAM API key > Would need to replace current scala HTTP library with OkHttp library, and > also replace play-json with GSON library. -- This message was sent by Atlassian JIRA (v6.4.14#64029)