[
https://issues.apache.org/jira/browse/BAHIR-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764646#comment-16764646
]
ASF GitHub Bot commented on BAHIR-193:
--------------------------------------
lresende commented on issue #43: BAHIR-193: facilitate scala version change
URL: https://github.com/apache/bahir-flink/pull/43#issuecomment-462211901
Flink seems to use something similar, but most of the other projects I have
worked before (e.g. Apache Spark) use the current approach used in Bahir. Also,
it seems scala best practices to have all artifacts published with the version
as part of the artifact name (e.g. _2.11 or _2.12).
Now, back to the build, my understanding is that, when you have the parent
pom released, it becomes a static file, and the pre-defined scala.version is
also static. So, when a project add a dependency on
`<flink-connector-kudu_2.12>` it will have a transient dependency to
`<flink_parent>` that has a `scala.binary.version` defined as 2.11, unless it
provides the same infrastructure of profiles in their build to override the
property, no?
Please let me know what you think, and in the meantime, I will play with it
a little more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> changes so scala version modifications are easier
> -------------------------------------------------
>
> Key: BAHIR-193
> URL: https://issues.apache.org/jira/browse/BAHIR-193
> Project: Bahir
> Issue Type: Improvement
> Components: Flink Streaming Connectors
> Reporter: Joao Boto
> Assignee: Joao Boto
> Priority: Major
>
> remove scala version from artifact name on parent
> on modules set scala version by parameter with ${scala.binary.version}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
