[
https://issues.apache.org/jira/browse/BAHIR-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800633#comment-16800633
]
ASF GitHub Bot commented on BAHIR-202:
--------------------------------------
eskabetxe commented on pull request #50: [BAHIR-202] Improve KuduSink
throughput by using async FlushMode
URL: https://github.com/apache/bahir-flink/pull/50#discussion_r268613593
##########
File path:
flink-connector-kudu/src/main/java/org/apache/flink/streaming/connectors/kudu/KuduSink.java
##########
@@ -79,9 +86,12 @@ public KuduSink(String kuduMasters, KuduTableInfo
tableInfo, KuduSerialization<O
@Override
public void open(Configuration parameters) throws IOException {
- if (connector != null) return;
- connector = new KuduConnector(kuduMasters, tableInfo, consistency,
writeMode);
- serializer.withSchema(tableInfo.getSchema());
+ if (this.connector != null) return;
+ FlushMode flushMode = ((StreamingRuntimeContext)
getRuntimeContext()).isCheckpointingEnabled() ?
Review comment:
yes, maybe we have to rethink this.
we are forcing to chose strong or eventual consistence, but seems that some
flush modes are not ok with any of these options..
could your create a new issue so we can discuss the best option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve KuduSink throughput by using async FlushMode
> ----------------------------------------------------
>
> Key: BAHIR-202
> URL: https://issues.apache.org/jira/browse/BAHIR-202
> Project: Bahir
> Issue Type: Improvement
> Components: Flink Streaming Connectors
> Affects Versions: Flink-1.0
> Reporter: Suxing Lee
> Priority: Major
> Fix For: Flink-Next
>
>
> Improve KuduSink throughput by using async FlushMode.
> And using checkpoint to ensure at-least-once in async flush mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
