[
https://issues.apache.org/jira/browse/BAHIR-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858690#comment-16858690
]
ASF GitHub Bot commented on BAHIR-205:
--------------------------------------
liketic commented on pull request #57: [BAHIR-205] Support configure password
for redis cluster
URL: https://github.com/apache/bahir-flink/pull/57#discussion_r291611667
##########
File path:
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfigTest.java
##########
@@ -46,4 +48,20 @@ public void
shouldThrowIllegalArgumentExceptionIfNodeValuesAreEmpty(){
.setNodes(set)
.build();
}
+
+ @Test
+ public void shouldSetPasswordSuccessfully() {
Review comment:
I added the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add password support for flink sink of redis cluster
> -----------------------------------------------------
>
> Key: BAHIR-205
> URL: https://issues.apache.org/jira/browse/BAHIR-205
> Project: Bahir
> Issue Type: Improvement
> Components: Flink Streaming Connectors
> Affects Versions: Not Applicable
> Reporter: yanfeng
> Priority: Major
> Labels: features
> Fix For: Not Applicable
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> redis cluster with password protect is not supported in
> flink-connector-redis_2.11 version 1.1-SNAPSHOT, because the related jedis
> 2.8.0 doesn't support the feature, so uprade jedis to 2.9.0 and some code
> will fulfill it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
