I've a proposal design doc here https://docs.google.com/document/d/1YlCWws4SYCqUWAtVz9mrmVdFNM8b3E8DLCImYep-I6k/edit# which try to share the same code of KafkaIO. Due to the API change of Kafka Consumer.class, it's nearly impossible to have a single module for both kafka 0.9 and 0.10, unless reflection at runtime.
On Wed, Feb 8, 2017 at 10:09 AM, Stephen Sisk <[email protected]> wrote: > hi JB! > > Can you explain what you mean by easier to maintain? Is that because of > maven dependency management, or some other factor? If we need to go with 2 > modules for dependency reasons, is there a way to share code between those > two modules so that we don't have 2 copies of the code? (or is the copied > code desirable b/c of very different code needs?) > > S > > On Mon, Feb 6, 2017 at 2:44 PM Jean-Baptiste Onofré <[email protected]> > wrote: > > > Go ahead ! > > > > My suggestion was to create one IO module per version (kafka-0.9, > > kafka-0.10 for instance). > > > > I think it's easier to maintain. > > > > Regards > > JB > > > > On Feb 6, 2017, 15:35, at 15:35, Xu Mingmin <[email protected]> wrote: > > >Hello, > > > > > >Is there anybody working on > > >https://issues.apache.org/jira/browse/BEAM-307? > > >The existing KafkaIO is implemented with Kafka 0.9, and not compatible > > >well > > >with Kafka 0.10. > > > > > >I'd like to take this task if not duplicated: > > >1). a new KafkaIO based on Kafka 0.10, suggest a separated project for > > >easy-to-build; > > >2). use timestamp of Kafka message as default event-timestamp > > > > > >Thanks! > > >Mingmin > > >
