Hi Dan,
good points.
IMHO, as it's just for test (#2), just the compiler flag is enough (in a
profile or not).
Regards
JB
On 02/27/2017 07:01 PM, Dan Halperin wrote:
I think there are a few separable questions:
1. Can the module itself be used with Java7 only, and can we enforce this?
2. When testing, can we use Java 8 dependencies and how?
I think that the automated enforcements are useful to ensure property #1,
assuming we want the module to work in Java7. Not enforcing it means we're
at risk of losing it. So I'm not a fan of simply disabling these checks.
However, it should be possible to use java8 code as well. Maybe it goes in
a profile? Maybe it goes into a separate module, maybe just a separate
profile?
Can you investigate?
On Mon, Feb 27, 2017 at 9:23 AM, Jean-Baptiste Onofré <[email protected]>
wrote:
Hi Dipti,
I had the same "issue" on CassandraIO.
If you take a look on:
https://github.com/apache/beam/pull/592/files
you will see that I use <compiler.error.flag></compiler.error.flag> to
remove the default -Werror causing issue with Java8 dependencies.
Regards
JB
On 02/27/2017 06:16 PM, Dipti Kulkarni wrote:
Hi all,
While working on HadoopInputFormatIO, when I rebased my code to fetch the
latest from Beam repo, I see an Enforcer rule added to the parent POM to
ensure that all dependencies used are compliant with JDK 1.7
I have written tests for Cassandra and Elasticsearch to test if HIFIO
works ok to read data from these sources using their respective inputformat
classes, for these tests, I am using the latest version of ES, and
Cassandra which need dependencies working on JDK 1.8.
These dependencies are marked as test scope, .and my builds continue to
fail due to the Banned Dependency error. Is it mandatory for the tests
also to comply with the enforcer rule of JDK 1.7? Or is there any way we
can override the JDK compliance for Tests? Thoughts?
-Dipti
DISCLAIMER
==========
This e-mail may contain privileged and confidential information which is
the property of Persistent Systems Ltd. It is intended only for the use of
the individual or entity to which it is addressed. If you are not the
intended recipient, you are not authorized to read, retain, copy, print,
distribute or use this message. If you have received this communication in
error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected
mails.
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
