+1 (binding) Pei, I filed https://issues.apache.org/jira/browse/BEAM-2283 about using a consistent strategy when dealing with URIs/string like paths in our APIs and related the bugs that you filed to it.
On Mon, May 15, 2017 at 6:56 AM, Pei HE <pei...@gmail.com> wrote: > Currently, several unit tests fail in Windows OS, and the beam repo fails > to build. (tested in Windows 7) > > (Then, I built the jar manually in mac, and copied it to Windows OS) > > Found WordCount also doesn't work with Windows OS local files. > > Filed two jira: > https://issues.apache.org/jira/browse/BEAM-2298 > https://issues.apache.org/jira/browse/BEAM-2299 > > > On Mon, May 15, 2017 at 6:30 AM, Aljoscha Krettek <aljos...@apache.org> > wrote: > > > +1 > > > > Verified signatures > > Ran Quickstart code (WordCound, HourlyTeamScore, UserScore) on Flink on > > YARN on Dataproc > > > > > On 14. May 2017, at 21:06, Chamikara Jayalath <chamik...@apache.org> > > wrote: > > > > > > +1 > > > > > > Verified Python SDK examples (WordCount, BigQuery tornadoes, UserScore, > > and > > > HourlyTeamScore) on Windows for DirectRunner and DataflowRunner. > > > > > > Verified all checksums and signatures. > > > > > > Thanks, > > > Cham > > > > > > > > > On Sun, May 14, 2017 at 3:15 AM Ismaël Mejía <ieme...@gmail.com> > wrote: > > > > > >> +1 (non-binding) > > >> > > >> Validated signatures OK > > >> Run mvn clean verify -Prelease OK > > >> Executed Nexmark with Direct/Spark/Flink/Apex runners in local mode > > >> (temporally downgraded to 2.0.0 to validate the version). OK > > >> > > >> This is looking great now. As Robert said, a release to be proud of. > > >> > > >> On Sun, May 14, 2017 at 8:25 AM, Robert Bradshaw > > >> <rober...@google.com.invalid> wrote: > > >>> +1 > > >>> > > >>> Verified all the checksums and signatures. (Now that both md5 and > sha1 > > >>> are broken, we should probably provide sha-256 as well.) > > >>> > > >>> Spot checked the site and documentation, left comments on the PR. The > > >>> main landing page has nothing about the Beam stable release, and the > > >>> top blog entry (right in the center) mentions 0.6.0 which catches the > > >>> eye. I assume a 2.0.0 blog will be here shortly? > > >>> > > >>> Ran a couple of trivial but novel direct-runner pipelines (Python and > > >> Java). > > >>> > > >>> https://github.com/tensorflow/transform is pinning 0.6.0, so we > won't > > >>> break them (though hopefully they'll upgrade to >=2.0.0 shortly after > > >>> the release). > > >>> > > >>> The Python zipfile at > > >>> https://dist.apache.org/repos/dist/dev/beam/2.0.0-RC4/ is missing > > >>> sdks/python/apache_beam/transforms/trigger_transcripts.yaml. This > will > > >>> cause some tests to be skipped (but no failure). However, I don't > > >>> think it's worth cutting another release candidate for. > > >>> > > >>> Everything else is looking great. This is a release to be proud of! > > >>> > > >>> - Robert > > >>> > > >>> > > >>> > > >>> On Sat, May 13, 2017 at 8:40 PM, Mingmin Xu <mingm...@gmail.com> > > wrote: > > >>>> +1 > > >>>> > > >>>> Test beam-examples with FlinkRunner, and several cases of > > >> KafkaIO/JdbcIO. > > >>>> > > >>>> Thanks! > > >>>> Mingmin > > >>>> > > >>>> On Sat, May 13, 2017 at 7:38 PM, Ahmet Altay > <al...@google.com.invalid > > > > > >>>> wrote: > > >>>> > > >>>>> +1 > > >>>>> > > >>>>> - Tested Python wordcount with DirectRunner & DataflowRunner on > > >>>>> Windows/Mac/Linux, and python mobile gaming examples with > > DirectRunner > > >> & > > >>>>> DataflowRunner on Mac/Linux > > >>>>> - Verified that generated pydocs are accurate. > > >>>>> - Python zip file has valid metadata and contains LICENSE, NOTICE > and > > >>>>> README. > > >>>>> > > >>>>> Ahmet > > >>>>> > > >>>>> On Sat, May 13, 2017 at 1:12 AM, María García Herrero < > > >>>>> mari...@google.com.invalid> wrote: > > >>>>> > > >>>>>> +1 -- validated python quickstart and mobile game for DirectRunner > > >> and > > >>>>>> DataflowRunner on Linux (RC3) and Mac (RC4). > > >>>>>> > > >>>>>> Go Beam! > > >>>>>> > > >>>>>> On Fri, May 12, 2017 at 11:12 PM, Jean-Baptiste Onofré < > > >> j...@nanthrax.net> > > >>>>>> wrote: > > >>>>>> > > >>>>>>> +1 (binding) > > >>>>>>> > > >>>>>>> Tested on beam-samples, especially focus on HDFS support, etc. > > >>>>>>> > > >>>>>>> Thanks ! > > >>>>>>> Regards > > >>>>>>> JB > > >>>>>>> > > >>>>>>> > > >>>>>>> On 05/13/2017 06:47 AM, Davor Bonaci wrote: > > >>>>>>> > > >>>>>>>> Hi everyone -- > > >>>>>>>> After going through several release candidates, setting and > > >> validating > > >>>>>>>> acceptance criteria, running a hackathon, and polishing the > > >> release, > > >>>>> now > > >>>>>>>> is > > >>>>>>>> the time to vote! > > >>>>>>>> > > >>>>>>>> Please review and vote on the release candidate #4 for the > version > > >>>>>> 2.0.0, > > >>>>>>>> as follows: > > >>>>>>>> [ ] +1, Approve the release > > >>>>>>>> [ ] -1, Do not approve the release (please provide specific > > >> comments) > > >>>>>>>> > > >>>>>>>> The complete staging area is available for review, which > includes: > > >>>>>>>> * JIRA release notes [1], > > >>>>>>>> * the official Apache source release to be deployed to > > >>>>> dist.apache.org > > >>>>>>>> [2], > > >>>>>>>> which is signed with the key with fingerprint 8F0D334F [3], > > >>>>>>>> * all artifacts to be deployed to the Maven Central Repository > > >> [4], > > >>>>>>>> * source code tag "v2.0.0-RC4" [5], > > >>>>>>>> * website pull request listing the release and publishing the > API > > >>>>>>>> reference > > >>>>>>>> manual [6], > > >>>>>>>> * Python artifacts are deployed along with the source release to > > >> the > > >>>>>>>> dist.apache.org [2]. > > >>>>>>>> > > >>>>>>>> Jenkins suites: > > >>>>>>>> * https://builds.apache.org/job/beam_PreCommit_Java_ > > >>>>> MavenInstall/11439/ > > >>>>>>>> * https://builds.apache.org/job/beam_PostCommit_Java_ > > >>>>> MavenInstall/3801/ > > >>>>>>>> * > > >> https://builds.apache.org/job/beam_PostCommit_Python_Verify/2216/ > > >>>>>>>> * > > >>>>>>>> https://builds.apache.org/job/beam_PostCommit_Java_Validates > > >>>>>>>> Runner_Apex/1461/ > > >>>>>>>> * > > >>>>>>>> https://builds.apache.org/job/beam_PostCommit_Java_Validates > > >>>>>>>> Runner_Dataflow/3123/ > > >>>>>>>> * > > >>>>>>>> https://builds.apache.org/job/beam_PostCommit_Java_Validates > > >>>>>>>> Runner_Flink/2808/ > > >>>>>>>> * > > >>>>>>>> https://builds.apache.org/job/beam_PostCommit_Java_Validates > > >>>>>>>> Runner_Spark/2060/ > > >>>>>>>> > > >>>>>>>> The vote will be open for at least 72 hours. It is adopted by > > >> majority > > >>>>>>>> approval of qualified votes, with at least 3 PMC affirmative > > >> votes. > > >>>>>>>> > > >>>>>>>> Thanks! > > >>>>>>>> > > >>>>>>>> Davor > > >>>>>>>> > > >>>>>>>> [1] > > >>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > > >>>>>>>> ctId=12319527&version=12339746 > > >>>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.0.0-RC4/ > > >>>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS > > >>>>>>>> [4] https://repository.apache.org/ > content/repositories/orgapache > > >>>>>>>> beam-1017/ > > >>>>>>>> [5] https://github.com/apache/beam/tree/v2.0.0-RC4 > > >>>>>>>> [6] https://github.com/apache/beam-site/pull/231 > > >>>>>>>> [7] > > >>>>>>>> https://lists.apache.org/thread.html/981c2f13c0daf29876059b1 > > >>>>>>>> 4dbe97e75bcc9e40d3ac38e33a6ecf3f9@%3Cdev.beam.apache.org%3E > > >>>>>>>> [8] > > >>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D% > > >>>>>>>> 20BEAM%20AND%20fixVersion%20%3D%202.0.0%20AND%20resolution% > > >>>>>>>> 20%3D%20Unresolved%20ORDER%20BY%20component%20ASC%2C%20su > > >>>>>>>> mmary%20ASC%2C%20assignee%20ASC%2C%20due%20ASC%2C%20priority > > >>>>>>>> %20DESC%2C%20created%20ASC > > >>>>>>>> > > >>>>>>>> > > >>>>>>> -- > > >>>>>>> Jean-Baptiste Onofré > > >>>>>>> jbono...@apache.org > > >>>>>>> http://blog.nanthrax.net > > >>>>>>> Talend - http://www.talend.com > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>>> > > >>>> > > >>>> -- > > >>>> ---- > > >>>> Mingmin > > >> > > > > >
