+1

I think this is a good way to streamline HIFIO and native IOs.

Regards,
Seshadri
408 601 7548

-----Original Message-----
From: Ismaël Mejía [mailto:[email protected]] 
Sent: Tuesday, May 30, 2017 1:47 PM
To: [email protected]
Subject: Re: [DISCUSS] HadoopInputFormat based IOs

The whole goal of this discussion is that we define what shall we do when 
someone wants to add a new IO that uses HIFIO. The consensus so far following 
the PR comments + this thread is that it should be discouraged and those 
contribution be included as documentation in the website, and that we should 
give priority to the native implementations, which seems reasonable (e,g, to 
encourage better implementations and avoid the maintenance burden).

So, I was wondering what would be a good rule to justify that we have tests for 
some data stores as part of the tests of HIFIO and I don't see a strong reason 
to do this, in particular once those have native implementations, to be more 
clear, in the current case we have HIFIO tests (jdk1.8-tests) for 
Elasticsearch5 and Cassandra which both are not covered by the native IOs yet. 
However once the native IOs for both systems are merged I don't see any reason 
to keep the extra tests in HIFIO, because we will be doing a double effort to 
test an IO that is not native, and that does not support Write, so I think we 
should remove those. Also not having this in the source code base would be 
consistent with the ideas of the previous paragraph.

But well maybe I am missing something here, do you see any strong reason to 
keep them.

Reply via email to