Thanks. Let's wait for Jenkins to report the same and we can review it
again.

On Mon, Jul 10, 2017 at 10:57 PM, Ted Yu <[email protected]> wrote:

> Looks like (some of) the findbugs warnings were not addressed.
>
> e.g. in TopWikipediaSessions.java :
>
>                   if (Math.abs(c.element().hashCode()) <=
> Integer.MAX_VALUE
> * samplingThreshold) {
>
> See
> https://stackoverflow.com/questions/23416264/bad-
> attempt-to-compute-absolute-value
> for why findbugs gave warning.
>
> FYI
>
> On Mon, Jul 10, 2017 at 10:01 AM, Apache Enthu <[email protected]>
> wrote:
>
> > Thanks Kenneth. Unfortunately i'm still unable to reproduce the issue.
> Did
> > anyone had a chance to look at the other issue that i raised in my mail?
> > Unfortunately as i am not a committer and hence am assuming i wont be
> > entitle to create jira for the same.
> >
> > [INFO] --- maven-checkstyle-plugin:2.17:check (default) @
> > beam-examples-java ---
> > [INFO] Starting audit...
> > Audit done.
> > [INFO]
> > [INFO] >>> findbugs-maven-plugin:3.0.4:check (default) > :findbugs @
> > beam-examples-java >>>
> > [INFO]
> > [INFO] --- findbugs-maven-plugin:3.0.4:findbugs (findbugs) @
> > beam-examples-java ---
> > [INFO] Downloading:
> > http://nexus.codehaus.org/snapshots/org/apache/beam/
> > beam-sdks-java-build-tools/2.2.0-SNAPSHOT/maven-metadata.xml
> > [WARNING] Could not transfer metadata
> > org.apache.beam:beam-sdks-java-build-tools:2.2.0-
> > SNAPSHOT/maven-metadata.xml
> > from/to codehaus-snapshots (http://nexus.codehaus.org/snapshots/):
> > nexus.codehaus.org
> > [INFO]
> > [INFO] <<< findbugs-maven-plugin:3.0.4:check (default) < :findbugs @
> > beam-examples-java <<<
> > [INFO]
> > [INFO] --- findbugs-maven-plugin:3.0.4:check (default) @
> > beam-examples-java
> > ---
> > [INFO]
> > [INFO] --- maven-surefire-plugin:2.20:test (default-test) @
> > beam-examples-java ---
> >
> >
> > On Mon, Jul 10, 2017 at 9:09 AM, Kenneth Knowles <[email protected]
> >
> > wrote:
> >
> > > I think the key line you will want to change is here:
> > > https://github.com/apache/beam/blob/master/examples/java/pom.xml#L375
> > >
> > > On Sun, Jul 9, 2017 at 12:17 AM, Apache Enthu <[email protected]>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > Is BEAM-933 already fixed? I'm unable to reproduce the bug by running
> > > maven
> > > > build. Here's what i see:
> > > >
> > > > [INFO] --- maven-compiler-plugin:3.6.1:testCompile
> > > (default-testCompile) @
> > > > beam-examples-java ---
> > > > [INFO] Changes detected - recompiling the module!
> > > > [INFO] Compiling 15 source files to
> > > > C:\workspace-apache\beam\examples\java\target\test-classes
> > > > [INFO]
> > > > /C:/workspace-apache/beam/examples/java/src/test/java/
> > > > org/apache/beam/examples/WindowedWordCountIT.java:
> > > > C:\workspace-apache\beam\examples\java\src\test\java\
> > > > org\apache\beam\examples\WindowedWordCountIT.java
> > > > uses or overrides a deprecated API.
> > > > [INFO]
> > > > /C:/workspace-apache/beam/examples/java/src/test/java/
> > > > org/apache/beam/examples/WindowedWordCountIT.java:
> > > > Recompile with -Xlint:deprecation for details.
> > > > [INFO]
> > > > /C:/workspace-apache/beam/examples/java/src/test/java/
> > > > org/apache/beam/examples/complete/AutoCompleteTest.java:
> > > > Some input files use unchecked or unsafe operations.
> > > > [INFO]
> > > > /C:/workspace-apache/beam/examples/java/src/test/java/
> > > > org/apache/beam/examples/complete/AutoCompleteTest.java:
> > > > Recompile with -Xlint:unchecked for details.
> > > > [INFO]
> > > >
> > > >
> > > >
> > > > *[INFO] --- maven-checkstyle-plugin:2.17:check (default) @
> > > > beam-examples-java ---[INFO] Starting audit...Audit done.*[INFO]
> > > > [INFO] --- maven-surefire-plugin:2.20:test (default-test) @
> > > > beam-examples-java ---
> > > > [INFO]
> > > >
> > > > Could you please check and let me know, so we could close this issue.
> > > >
> > > > Also there seems to be an issue with DebuggingWordCountTest, running
> on
> > > > Windows. It says:
> > > >
> > > >
> > > > *org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> > > > java.lang.IllegalStateException: Unable to find registrar for c*
> at
> > > > org.apache.beam.sdk.Pipeline.run(Pipeline.java:303)
> > > >     at org.apache.beam.sdk.Pipeline.run(Pipeline.java:283)
> > > >     at
> > > > org.apache.beam.examples.DebuggingWordCount.main(
> > > > DebuggingWordCount.java:160)
> > > >     at
> > > > org.apache.beam.examples.DebuggingWordCountTest.
> > testDebuggingWordCount(
> > > > DebuggingWordCountTest.java:53)
> > > >     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > > >     at
> > > > sun.reflect.NativeMethodAccessorImpl.invoke(
> > > NativeMethodAccessorImpl.java:
> > > > 62)
> > > >     at
> > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > > > DelegatingMethodAccessorImpl.java:43)
> > > >     at java.lang.reflect.Method.invoke(Method.java:498)
> > > >     at
> > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> > > > FrameworkMethod.java:50)
> > > >     at
> > > > org.junit.internal.runners.model.ReflectiveCallable.run(
> > > > ReflectiveCallable.java:12)
> > > >     at
> > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(
> > > > FrameworkMethod.java:47)
> > > >     at
> > > > org.junit.internal.runners.statements.InvokeMethod.
> > > > evaluate(InvokeMethod.java:17)
> > > >     at org.junit.rules.ExternalResource$1.evaluate(
> > > > ExternalResource.java:48)
> > > >     at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > > >     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> > > >     at
> > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(
> > > > BlockJUnit4ClassRunner.java:78)
> > > >     at
> > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(
> > > > BlockJUnit4ClassRunner.java:57)
> > > >     at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> > > >     at org.junit.runners.ParentRunner$1.schedule(
> ParentRunner.java:71)
> > > >     at org.junit.runners.ParentRunner.runChildren(
> > ParentRunner.java:288)
> > > >     at org.junit.runners.ParentRunner.access$000(
> ParentRunner.java:58)
> > > >     at org.junit.runners.ParentRunner$2.evaluate(
> > ParentRunner.java:268)
> > > >     at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> > > >     at
> > > > org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(
> > > > JUnit4TestReference.java:86)
> > > >     at
> > > > org.eclipse.jdt.internal.junit.runner.TestExecution.
> > > > run(TestExecution.java:38)
> > > >     at
> > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.
> > > > runTests(RemoteTestRunner.java:459)
> > > >     at
> > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.
> > > > runTests(RemoteTestRunner.java:675)
> > > >     at
> > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.
> > > > run(RemoteTestRunner.java:382)
> > > >     at
> > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.
> > > > main(RemoteTestRunner.java:192)
> > > > Caused by: java.lang.IllegalStateException: Unable to find registrar
> > > for c
> > > >     at
> > > > org.apache.beam.sdk.io.FileSystems.getFileSystemInternal(
> > > > FileSystems.java:447)
> > > >     at org.apache.beam.sdk.io.FileSystems.match(FileSystems.
> java:111)
> > > >     at
> > > > org.apache.beam.sdk.io.FileBasedSource.getEstimatedSizeBytes(
> > > > FileBasedSource.java:207)
> > > >     at
> > > > org.apache.beam.runners.direct.BoundedReadEvaluatorFactory$
> > > InputProvider.
> > > > getInitialInputs(BoundedReadEvaluatorFactory.java:207)
> > > >     at
> > > > org.apache.beam.runners.direct.ReadEvaluatorFactory$InputProvider.
> > > > getInitialInputs(ReadEvaluatorFactory.java:87)
> > > >     at
> > > > org.apache.beam.runners.direct.RootProviderRegistry.
> getInitialInputs(
> > > > RootProviderRegistry.java:62)
> > > >
> > > >
> > > > I have fixed this locally but i dont have permission to create the
> > jira.
> > > > Could you please let me know the procedure to get me entitled to
> create
> > > and
> > > > update jira?
> > > >
> > > > https://beam.apache.org/contribute/ Doesn't have much info about the
> > > same.
> > > >
> > > > Thanks,
> > > > Almas
> > > >
> > >
> >
>

Reply via email to