Regards JB
On 11/07/2017 06:42 PM, Reuven Lax wrote:
Even after redoing things, all the generated files (I think they are auto-generated protocol buffer files) in sdks/python/apache_beam/portability/api are still there. I think these files may be new since the last release, so we didn't deal with this last time. On Tue, Nov 7, 2017 at 9:32 AM, Jean-Baptiste Onofré <j...@nanthrax.net> wrote:Yeah, no problem to rename the file. Regards JB On 11/07/2017 06:30 PM, Reuven Lax wrote:JB, when I try and regenerate the sources using the command you suggested on the issue, it generates apache-beam-2.2.0-SNAPSHOT-source-release.zip instead of apache-beam-2.2.0-source-release.zip Is it safe to simply rename those files, or is the wrong thing being generated? On Mon, Nov 6, 2017 at 8:50 PM, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: Agree, it's what I did in previous release (with git clean -x as well).Thanks ! Regards JB On 11/07/2017 05:47 AM, Reuven Lax wrote: As we've done before, I will manually clean up these directories andregenerate the zip. I don't think there's a need for another RC. On Mon, Nov 6, 2017 at 8:42 PM, Reuven Lax <re...@google.com> wrote: Actually, I think this is https://issues.apache.org/jira /browse/BEAM-2271. Appears we hit this on every release. On Mon, Nov 6, 2017 at 4:23 PM, Reuven Lax <re...@google.com> wrote: Yes, if you see anything obvious that would be helpful! I'm getting on a17-hour flight to Singapore tomorrow, so I would like to have a working RC out first. Meanwhile, since they only concern is extra stuff in the source dist, I think all other verifications can go on (in particular the artifacts shouldn't be changing). Reuven On Mon, Nov 6, 2017 at 11:34 AM, Jean-Baptiste Onofré < j...@nanthrax.net> wrote: Hi Reuven,do you want me to take a look ? I'm ready to help ! Regards JB On 11/05/2017 11:30 PM, Reuven Lax wrote: Built RC3, however many of these files/directories ended up in thesource zip again, despite my being careful to run a git clean -x -f this time. I'm not sure why, taking a look. On Sun, Nov 5, 2017 at 2:16 PM, Reuven Lax <re...@google.com> wrote: Last time is the charm - it succeeded this time!On Sun, Nov 5, 2017 at 1:22 PM, Reuven Lax <re...@google.com> wrote: BTW, I'm trying one more time.On Sun, Nov 5, 2017 at 12:02 PM, Reuven Lax <re...@google.com> wrote: yes, release:prepare worked fine.If you're able to do so, that would be great. I don't know the details well enough to try and manually upload the artifacts. On Sun, Nov 5, 2017 at 12:00 PM, Jean-Baptiste Onofré < j...@nanthrax.net> wrote: I guess that release:prepare step worked fine. So the tag is there.I can checkout on the tag and upload the artifacts on staging repo (as release:perform does). Regards JB On 11/05/2017 08:59 PM, Reuven Lax wrote: How would I go about doing this? Are there instructions on the releaseguide? On Sun, Nov 5, 2017 at 11:57 AM, Jean-Baptiste Onofré < j...@nanthrax.net wrote:It sounds like an issue on Nexus at Apache. I just checked on status.apache.org and nothing special aboutNexus. Do you want to try to upload artifacts (and then you can take hand using the staging repo) ? Regards JB On 11/05/2017 08:53 PM, Reuven Lax wrote: Unfortunately all attempts to cut RC03 now fail with [*INFO*] [ERROR] Failed to execute goalorg.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project beam-examples-java: Failed to deploy artifacts: Could not transfer artifact org.apache.beam:beam-examples- java:jar.asc:javadoc:2.2.0 from/to apache.releases.https ( https://repository.apache.org/service/local/staging/deploy/m aven2): Connect to repository.apache.org:443 [repository.apache.org/207.244 .88.140] failed: Operation timed out (Connection timed out) -> [Help 1] I've tried a few times. On Sat, Nov 4, 2017 at 9:53 PM, Jean-Baptiste Onofré < j...@nanthrax.net> wrote: I think it's wise, yes. RegardsJB On 11/05/2017 02:13 AM, Reuven Lax wrote: Trying to perform surgery on the source dist looks a bit too error prone, so I think I'll cut an RC3.On Fri, Nov 3, 2017 at 10:32 PM, Jean-Baptiste Onofré < j...@nanthrax.net> wrote: Yeah, at least the script can ask for human validation at some points of the process (as we do in the release guide). RegardsJB On Nov 3, 2017, 18:22, at 18:22, Reuven Lax <re...@google.com.INVALID> wrote: Of course. I don't think we can remove the release manager from the process, but I think I can automate it so that there are at leastfewer manual steps for the release manager to perform. On Fri, Nov 3, 2017 at 9:51 AM, Jean-Baptiste Onofré < j...@nanthrax.net wrote:Got it. But don't forget there is a release guide andsome manual validation to perform. A Apache release is not just a script to run,as a release manager, you are also responsible of theverification (legal, artifacts, etc).Regards JB On Nov 3, 2017, 17:45, at 17:45, Reuven Lax <re...@google.com.INVALID> wrote:What I meant is that there are many manual commands today,which makestheprocess more prone to human error at a number of points. Idon't thinkweneed to change the release process, I simply want to scriptit sothat therelease owner has to run fewer commands.On Fri, Nov 3, 2017 at 9:13 AM, Jean-Baptiste Onofré<j...@nanthrax.net> wrote:HiIf the tag is ok, updated artifacts require a new stagingrepository. Soit means the vote email is obsolete.I would cut a clean new rc3 and start a new vote.Regards JB On Nov 3, 2017, 16:30, at 16:30, Reuven Lax <re...@google.com.INVALID> wrote:Thanks for catching this.Do we need new artifacts? Looks like we might just needa new source drop.On Nov 3, 2017 11:27 AM, "Jean-Baptiste Onofré" <j...@nanthrax.net>wrote:Probably the cleanup (git clean -x) has not be done before cuttingtherelease.I would ask a new rc to fix the provided artifacts.Regards JB On Nov 3, 2017, 15:46, at 15:46, "Ismaël Mejía" <ieme...@gmail.com> wrote:I found some issues during the vote validation (notsure ifthosewould require a new vote since most seem to bepackagingrelatedandwe can get with it by removing the extra stuff that endedupinthezip files):1. I inspected the apache-beam-2.2.0-source-release.zip fileandwasabit surprised to notice that it was twice the size ofthe oneforthe2.1.0 vote, then I discovered that the sdks/python/,eggsdirectorywaspart of the 2.2.0 zip file (I suppose this is anissue).2. There are some directories/files that appear inthe zipfile thatdon't exist in the 2.2.0-rc2 git tag:2.1.1/foo/model/sdks/python/README.md 3. Then I run the rat validation and it broke because some files don'thave the correct (I suppose these are generated filesthatshouldnotbe part of the final distribution). This is a part of thereleaseprocess that we have done manually and that hasbitten us inthelatest two releases.[WARNING] Files with unapproved licenses:sdks/python/apache_beam/portability/api/beam_runner_api_pb2_ grpc.pysdks/python/apache_beam/portability/api/standard_window_fns_pb2.pysdks/python/apache_beam/portability/api/beam_job_api_pb2.pysdks/python/apache_beam/portability/api/endpoints_pb2.pysdks/python/apache_beam/portability/api/beam_artifact_api_ pb2_grpc.pysdks/python/apache_beam/portability/api/beam_artifact_api_pb 2.pysdks/python/apache_beam/portability/api/beam_fn_api_pb2_grpc.pysdks/python/apache_beam/portability/api/beam_fn_api_pb2.pysdks/python/apache_beam/portability/api/beam_runner_api_pb2.pysdks/python/apache_beam/portability/api/beam_provision_api_pb2.pysdks/python/apache_beam/portability/api/beam_job_api_pb2_grpc.pysdks/python/apache_beam/portability/api/endpoints_pb2_grpc.pysdks/python/apache_beam/portability/api/beam_provision_api_pb2_grpc.pysdks/python/apache_beam/portability/api/standard_window_fns_pb2_grpc.pyOn Wed, Nov 1, 2017 at 4:47 AM, Reuven Lax<re...@google.com.invalid>wrote:Hi everyone,Please review and vote on the release candidate #2for the version 2.2.0,as follows:[ ] +1, Approve the release[ ] -1, Do not approve the release (pleaseprovide specific comments)The complete staging area is available for your review,which includes:* JIRA release notes [1],* the official Apache source release to bedeployedto dist.apache.org [2], which is signed with the key with fingerprintB98B7708 [3],* all artifacts to be deployed to theMaven CentralRepository[4],* source code tag "v2.2.0-RC2" [5],* website pull request listing the release andpublishingtheAPIreference manual [6].* Java artifacts were built with Maven 3.5.0andOpenJDK/OracleJDK1.8.0_144.* Python artifacts are deployed along with thesourcereleasetothedist.apache.org [2].The vote will be open for at least 72 hours. It isadopted by majorityapproval, with at least 3 PMC affirmative votes.Thanks,Reuven [1] https://issues.apache.org/jira /secure/ReleaseNote.jspa? projectId=12319527&version=12341044[2] https://dist.apache.org/repos/dist/dev/beam/2.2.0/ [3] https://dist.apache.org/repos/dist/release/beam/KEYS [4]https://repository.apache.org/content/repositories/orgapachebeam-1022/[5] https://github.com/apache/beam/tree/v2.2.0-RC2[6] https://github.com/apache/beam-site/pull/337--Jean-Baptiste Onofréjbono...@apache.orghttp://blog.nanthrax.net Talend - http://www.talend.com --Jean-Baptiste Onofréjbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com --Jean-Baptiste Onofréjbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com--Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com--Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com-- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
-- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com