xumingming commented on issue #4168: [BEAM-3238][SQL] Add BeamRecordSqlTypeBuilder URL: https://github.com/apache/beam/pull/4168#issuecomment-346831152 I like this idea! One minor comment: Can we put the `BeamRecordSqlTypeBuilder` inside `BeamRecordSqlType`? it will keep the surface api of `org.apache.beam.sdk.extensions.sql` cleaner.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
