iemejia commented on a change in pull request #4174: [BEAM-3244] Ensure
execution of teardown method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#discussion_r153012280
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -380,7 +386,6 @@ public void close() throws Exception {
}
}
checkFinishBundleTimer.cancel(true);
Review comment:
@aljoscha I had the doubt if this one should be moved to dispose too, given
that close can eventually not be called. WDYT ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
