jkff commented on a change in pull request #4145: Many simplifications to
WriteFiles
URL: https://github.com/apache/beam/pull/4145#discussion_r153293639
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -527,13 +521,8 @@ public void processElement(ProcessContext c,
BoundedWindow window) throws Except
writer.cleanup();
throw e;
}
- int shardNumber =
- shardNumberAssignment == ShardAssignment.ASSIGN_WHEN_WRITING
- ? c.element().getKey().getShardNumber()
- : UNKNOWN_SHARDNUM;
- c.output(
- new FileResult<>(
- writer.getOutputFile(), shardNumber, window, c.pane(),
entry.getKey()));
+ int shard = c.element().getKey().getShardNumber();
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
