Thanks JB. Glad it seems like a simple thing to fix. On Wed, Dec 13, 2017 at 9:14 AM, Jean-Baptiste Onofré <[email protected]> wrote:
> Hi, > > No problem Henning ! > > That's actually the result of gradle build, you are right. > > And as I ran maven build just after, rat complained about the files > without license in go. > > It's the files located in sdks/go/vendor folder. > > I checked the .gitignore, I see vendor exclude. > > Let me check if git clean -x does the trick. > > Sorry for the noise. > > Regards > JB > > On 12/13/2017 05:32 PM, Henning Rohde wrote: > >> The Go SDK doesn't ship or distribute vendor files. However, the gradle >> build creates them during the build process. I believe I excluded these >> from various config when I added gradle support for Go, but evidently I >> forgot something. Sorry about the trouble. Can you clarify which files you >> mean? >> >> Thanks, >> Henning >> >> On Tue, Dec 12, 2017 at 11:44 PM, Jean-Baptiste Onofré <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi guys, >> >> I just noticed that the Go SDK ships vendor files. >> >> Many of these files don't have license header. >> >> I would like to double check, assuming we distribute these files, >> that they >> are Apache license compatible (not a Cat X): >> >> https://www.apache.org/legal/resolved.html >> <https://www.apache.org/legal/resolved.html> >> >> Can a Go SDK contributor update me about that ? >> >> On the other hand, the rat plugin configuration should be updated to >> exclude >> those vendor files. I'm preparing a PR about that. >> >> Thanks, >> Regards >> JB >> -- Jean-Baptiste Onofré >> [email protected] <mailto:[email protected]> >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> >> >> > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com >
