That was my mistake. I was trying to do a merge commit using git merge
button but modified the title which seems to have prevented the merge :(
There is new build failure that is a dependency issue and unrelated to
above merges. Seems like you are getting a different error though so I'm
unsure if this is what you are observing. I filed following JIRA for this.
Setting the protobuf dependency to latest ('protobuf>=3.2.0' in setup.py)
seems to fix the issue.
https://issues.apache.org/jira/browse/BEAM-3357
- Cham
On Fri, Dec 15, 2017 at 12:31 AM Jean-Baptiste Onofré <[email protected]>
wrote:
> Hi guys,
>
> Yesterday, I submitted a PR to fix a test issue on the Python SDK:
>
> https://github.com/apache/beam/pull/4262
>
> However, last night, new set of commits introduced new Python test/build
> failure.
>
> Especially this one is affecting Jenkins and I can reproduce it on my
> machine:
>
> TypeError: __new__() got an unexpected keyword argument 'file'
> ERROR: InvocationError:
> '/home/jbonofre/Workspace/beam/sdks/python/target/.tox/py27gcp/bin/python
> apache_beam/examples/complete/autocomplete_test.py'
>
> I'm preparing a new PR to fix that.
>
> I also saw bunch of commits with a very light comment and no reference
> about a Jira:
>
> commit 79e167f1e0266508a66e6611ff024ef0797b95b7
> Author: Maria Garcia Herrero <[email protected]>
> Date: Thu Dec 14 14:13:42 2017 -0800
>
> Add review commnets
>
> commit d1db15d220ea7c21a5b758bf4de41ddfbba7f816
> Author: Maria Garcia Herrero <[email protected]>
> Date: Sun Dec 10 02:14:59 2017 -0800
>
> borrar
>
> commit 679a92d44c7e540114b7a92e9dbf823108740526 <(310)%20874-0526>
> Author: Maria Garcia Herrero <[email protected]>
> Date: Sat Dec 9 14:10:11 2017 -0800
>
> Address review comments
>
> commit 516e04ced3aaba1f6202a17ee55b9874136e29f8
> Author: Maria Garcia Herrero <[email protected]>
> Date: Thu Nov 30 11:12:03 2017 -0800
>
> Add review comments
>
> commit ec7615b9e90aee3eb7afae9c1d6f2c37675603f8
> Author: Maria Garcia Herrero <[email protected]>
> Date: Sat Nov 18 21:49:05 2017 -0800
>
> Fix linter error
>
> commit 6bcf84f2455bbb3fe3eb4d736e19acf299f472bc
> Author: Maria Garcia Herrero <[email protected]>
> Date: Fri Oct 20 11:14:54 2017 -0700
>
> Add Python processing-time timers and clock injection
>
> That would great to provide some details and, when possible, squash with a
> Jira
> reference.
>
> It helps to understand the change and eventually track breaking changes.
>
> Thanks !
> Regards
> JB
>
> On 12/13/2017 02:49 PM, Jean-Baptiste Onofré wrote:
> > Hi guys,
> >
> > It seems that following commit breaks the Python SDK build:
> >
> > commit 60dd7c4035a8d320b01823cbd4c959d0ef09cf26
> > Author: Robert Bradshaw <[email protected]>
> > Date: Tue Dec 12 17:30:59 2017 -0800
> >
> > It happens on my machine, on Jenkins (nightly build) and it's affecting
> the PR.
> >
> > I'm investigating to provide a PR to fix that.
> >
> > Sorry for the inconvenience.
> >
> > Regards
> > JB
>
> --
> Jean-Baptiste Onofré
> [email protected]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
