+1 to these being minimal criteria. (I assume there's an implicit "the coverage is the same or better" as well?)
On Fri, Dec 15, 2017 at 12:37 PM, Lukasz Cwik <[email protected]> wrote: > Romain, choosing the criteria is about setting the minimum expectations and > your welcome to suggest alternative criteria. > Even though the criteria is the minimum expectations we can see that the > Gradle build has averaged 130 mins while the maven build has averaged 201 > mins for the Java pre-commit. > > On Fri, Dec 15, 2017 at 12:13 PM, Romain Manni-Bucau <[email protected]> > wrote: >> >> If it is the ~same Im not sure i see the point to move but please dont >> keep gradle and mvn in master - more than jenkins ;). It makes it hard to >> follow the project and do prs. >> >> Le 15 déc. 2017 20:42, "Lukasz Cwik" <[email protected]> a écrit : >>> >>> I'm proposing that the criteria to remove a PreCommit/PostCommit running >>> in Jenkins via Maven is that and any Maven based configuration supporting >>> the execution: >>> * The pass rate of the Jenkins job via Gradle is the same or better then >>> Maven over the past 7 days. >>> * The average execution time via Gradle is the same or better then Maven >>> over the past 7 days. >>> >>> I pulled down some initial stats for the relevant Jenkins jobs: >>> Test name,# Builds,Pass Rate (%),Build time (mins) >>> beam_PerformanceTests_Python,27,70.37,28.2 >>> beam_PerformanceTests_Spark,27,0.00,0.7 >>> beam_PostCommit_Java_JDK_Versions_Test,27,0.00,1.8 >>> beam_PostCommit_Java_MavenInstall,42,64.29,142.6 >>> beam_PostCommit_Java_MavenInstall_Windows,26,0.00,61.3 >>> beam_PostCommit_Java_ValidatesRunner_Apex,43,79.07,62.6 >>> beam_PostCommit_Java_ValidatesRunner_Dataflow,40,57.50,118.0 >>> beam_PostCommit_Java_ValidatesRunner_Flink,42,95.24,15.5 >>> beam_PostCommit_Java_ValidatesRunner_Spark,42,80.95,60.5 >>> beam_PostCommit_Python_ValidatesRunner_Dataflow,42,80.95,23.3 >>> beam_PostCommit_Python_Verify,42,73.81,72.2 >>> beam_PreCommit_Go_MavenInstall,140,96.43,5.1 >>> beam_PreCommit_Java_GradleBuild,139,36.69,129.6 >>> beam_PreCommit_Java_MavenInstall,136,39.71,201.2 >>> beam_PreCommit_Python_MavenInstall,140,51.43,123.8 > >
