Thanks Kenn for the reminder ! Very useful

Regards
JB

On 30/01/2018 17:33, Kenneth Knowles wrote:
Hi all,

In the history I see merge commits like:

     "Merge pull request #12345 from some_user/random-branch-name"

This is GitHub's default, but it is quite silly. The branch name is not informative and also not important. It is also subject to deletion any time so you can't follow it to learn anything. This is why the committer guide instructs to make a useful message:

https://beam.apache.org/contribute/committer-guide/#merging-it

You should end up with this:

     "Merge pull request #12345: [BEAM-XYZ] fix data loss bug in WobbleIO"

Ah, now that's much better.

Kenn

Reply via email to