Thank you Pablo for fixing this so quickly!

WBR,
Alexey

> On 21 Feb 2018, at 18:11, Pablo Estrada <pabl...@google.com> wrote:
> 
> Thank you Kenn! And my apologies to everyone for causing this trouble.
> Best
> -P.
> 
> On Wed, Feb 21, 2018 at 9:08 AM Kenneth Knowles <k...@google.com 
> <mailto:k...@google.com>> wrote:
> Thanks for the info on this. I went ahead and merged it since it had good 
> test coverage and was a simple change to fix the build.
> 
> On Wed, Feb 21, 2018 at 9:03 AM, Pablo Estrada <pabl...@google.com 
> <mailto:pabl...@google.com>> wrote:
> Hello all!
> As outlined in BEAM-3720, this is due to my adding Gauge metrics without 
> adding support for the portability framework around the same time that the 
> direct runner was swapped. Please don't despair. PR 
> https://github.com/apache/beam/pull/4719 
> <https://github.com/apache/beam/pull/4719> fixes this, and hopefully will be 
> merged soon.
> Best
> -P.
> 
> On Wed, Feb 21, 2018 at 12:52 AM Ismaël Mejía <ieme...@gmail.com 
> <mailto:ieme...@gmail.com>> wrote:
> For info, this issue is tracked and the fix is in progress:
> https://issues.apache.org/jira/browse/BEAM-3720 
> <https://issues.apache.org/jira/browse/BEAM-3720>
> 
> 
> 
> On Tue, Feb 20, 2018 at 4:43 PM, Jean-Baptiste Onofré <j...@nanthrax.net 
> <mailto:j...@nanthrax.net>> wrote:
> > I would wait a feedback from the original author of the commit.
> >
> > Regards
> > JB
> > Le 20 févr. 2018, à 16:42, Alexey Romanenko <aromanenko....@gmail.com 
> > <mailto:aromanenko....@gmail.com>> a
> > écrit:
> >>
> >> Yes, I switched back to  BundleBasedDirectRunner as default direct runner
> >> on current master and now it passes.
> >> So, my question was rather if we need to revert this or someone, who aware
> >> of this change, can take a look and fix it properly?
> >>
> >> WBR,
> >> Alexey
> >>
> >> On 20 Feb 2018, at 16:20, Jean-Baptiste Onofré < j...@nanthrax.net 
> >> <mailto:j...@nanthrax.net>> wrote:
> >>
> >> Yes it seems to be related to the change on the Python direct runner.
> >>
> >> Did you try to revert the change to see if it fixes the build ?
> >>
> >> Thanks
> >> Regards
> >> JB
> >> Le 20 févr. 2018, à 16:13, Alexey Romanenko < aromanenko....@gmail.com 
> >> <mailto:aromanenko....@gmail.com>> a
> >> écrit:
> >>>
> >>> Hi all,
> >>>
> >>> Jenkins job “ beam_PreCommit_Python_MavenInstall” has been constantly
> >>> failing for last 3 days.
> >>>
> >>> Last successful build (#3052) has been produced at Feb 16:
> >>>
> >>> https://builds.apache.org/job/beam_PreCommit_Python_MavenInstall/lastSuccessfulBuild/
> >>>  
> >>> <https://builds.apache.org/job/beam_PreCommit_Python_MavenInstall/lastSuccessfulBuild/>
> >>>
> >>> “ git bisect" says that the first commit, when it started to fail, was
> >>> 56081686bf7926b65a18dc7c7d2c4e4a9fd265e9
> >>>
> >>> Could someone take a look on this or I need to create new Jira for this?
> >>>
> >>> WBR,
> >>> Alexey
> >>
> >>
> >
> -- 
> Got feedback? go/pabloem-feedback <https://goto.google.com/pabloem-feedback>
> -- 
> Got feedback? go/pabloem-feedback

Reply via email to