Thank you and sorry for the delay. Been testing the fix the past few hours. This CP PR fixes the issue: https://github.com/apache/beam/pull/5658 .
On Thu, Jun 14, 2018 at 10:25 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > OK, I started the RC2, but I'm stopping the process to cut a new one. > > Is it ok from your side ? > > Regards > JB > > On 15/06/2018 01:54, Charles Chen wrote: > > Looks like there is something wrong with PR 5636 > > <https://github.com/apache/beam/pull/5636> which we cherry-picked > > above. It breaks leaderboard examples which previously passed. I've > > reopened the issue and will update this thread shortly. > > > > On Thu, Jun 14, 2018 at 12:55 PM Jean-Baptiste Onofré <j...@nanthrax.net > > <mailto:j...@nanthrax.net>> wrote: > > > > Sure, just in time ;) > > > > Regards > > JB > > > > On 14/06/2018 20:58, Charles Chen wrote: > > > Can you also merge the CP https://github.com/apache/beam/pull/5636 > for > > > https://issues.apache.org/jira/browse/BEAM-4549? > > > > > > On Thu, Jun 14, 2018 at 6:52 AM Jean-Baptiste Onofré > > <j...@nanthrax.net <mailto:j...@nanthrax.net> > > > <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net>>> wrote: > > > > > > FYI, I'm starting RC2 right now. > > > > > > Stay tuned ! > > > > > > Regards > > > JB > > > > > > On 06/06/2018 10:44, Jean-Baptiste Onofré wrote: > > > > Hi everyone, > > > > > > > > Please review and vote on the release candidate #1 for the > > version > > > > 2.5.0, as follows: > > > > > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > NB: this is the first release using Gradle, so don't be too > > harsh ;) A > > > > PR about the release guide will follow thanks to this > release. > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > * JIRA release notes [1], > > > > * the official Apache source release to be deployed to > > > dist.apache.org <http://dist.apache.org> < > http://dist.apache.org> > > > > [2], which is signed with the key with fingerprint C8282E76 > [3], > > > > * all artifacts to be deployed to the Maven Central > > Repository [4], > > > > * source code tag "v2.5.0-RC1" [5], > > > > * website pull request listing the release and publishing > > the API > > > > reference manual [6]. > > > > * Java artifacts were built with Gradle 4.7 (wrapper) and > > > OpenJDK/Oracle > > > > JDK 1.8.0_172 (Oracle Corporation 25.172-b11). > > > > * Python artifacts are deployed along with the source > > release to the > > > > dist.apache.org <http://dist.apache.org> > > <http://dist.apache.org> [2]. > > > > > > > > The vote will be open for at least 72 hours. It is adopted > > by majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Thanks, > > > > JB > > > > > > > > [1] > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12342847 > > > > [2] https://dist.apache.org/repos/dist/dev/beam/2.5.0/ > > > > [3] https://dist.apache.org/repos/dist/release/beam/KEYS > > > > [4] > > > > > > https://repository.apache.org/content/repositories/orgapachebeam-1041/ > > > > [5] https://github.com/apache/beam/tree/v2.5.0-RC1 > > > > [6] https://github.com/apache/beam-site/pull/463 > > > > > > > > > > -- > > > Jean-Baptiste Onofré > > > jbono...@apache.org <mailto:jbono...@apache.org> > > <mailto:jbono...@apache.org <mailto:jbono...@apache.org>> > > > http://blog.nanthrax.net > > > Talend - http://www.talend.com > > > > > > > -- > > Jean-Baptiste Onofré > > jbono...@apache.org <mailto:jbono...@apache.org> > > http://blog.nanthrax.net > > Talend - http://www.talend.com > > > > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com >
