The sql module's tests depend on mocks and mocks depend on sql module, so moving this to a separate module creates a weird dependency graph. I don't think it is strictly circular but it comes close. Can we just move the folder from 'src/test' to 'src/main' and mark everything @Experimental?
Andrew On Wed, Oct 3, 2018 at 2:28 AM Kai Jiang <jiang...@gmail.com> wrote: > Big +1. > > Best, > Kai > ᐧ > > On Mon, Oct 1, 2018 at 10:42 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > >> +1 >> >> it makes sense. >> >> Regards >> JB >> >> On 02/10/2018 01:32, Rui Wang wrote: >> > Hi Community, >> > >> > BeamSQL defines some mock classes (see mock >> > < >> https://github.com/apache/beam/tree/master/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/mock >> >) >> > in a test directory. As there is more than one module under sql >> > <https://github.com/apache/beam/tree/master/sdks/java/extensions/sql >> > now, >> > there is a need to share these mock classes among modules. >> > >> > So I want to move these mock classes to a separate module under sql >> > <https://github.com/apache/beam/tree/master/sdks/java/extensions/sql>, >> > so other modules' tests can depend on this mock module. >> > >> > >> > What do you think of this idea? >> > >> > >> > -Rui >> > >> > >> >> -- >> Jean-Baptiste Onofré >> jbono...@apache.org >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> >
