You two did so much verification I had a hard time finding something where my help was meaningful! :-)
I did run the Nexmark suite on the DirectRunner against 2.7.0 and 2.8.0 following https://beam.apache.org/documentation/sdks/java/nexmark/#running-smoke-suite-on-the-directrunner-local . It is admittedly a very silly test - the instructions leave immutability enforcement on, etc. But it does appear that there is a 30% degradation in query 8 and 15% in query 9. These are the pure Java tests, not the SQL variants. The rest of the queries are close enough that differences are not meaningful. I would ask a little more time to see what is going on here - is it a real performance issue or an artifact of how the tests are invoked, or ...? Kenn On Mon, Oct 22, 2018 at 6:20 PM Ahmet Altay <al...@google.com> wrote: > Hi all, > > Did you have a chance to review this RC? Between me and Robert we ran a > significant chunk of the validations. Let me know if you have any questions. > > Ahmet > > On Thu, Oct 18, 2018 at 5:26 PM, Ahmet Altay <al...@google.com> wrote: > >> Hi everyone, >> >> Please review and vote on the release candidate #1 for the version 2.8.0, >> as follows: >> [ ] +1, Approve the release >> [ ] -1, Do not approve the release (please provide specific comments) >> >> The complete staging area is available for your review, which includes: >> * JIRA release notes [1], >> * the official Apache source release to be deployed to dist.apache.org >> [2], which is signed with the key with fingerprint 6096FA00 [3], >> * all artifacts to be deployed to the Maven Central Repository [4], >> * source code tag "v2.8.0-RC1" [5], >> * website pull request listing the release and publishing the API >> reference manual [6]. >> * Python artifacts are deployed along with the source release to the >> dist.apache.org [2]. >> * Validation sheet with a tab for 2.8.0 release to help with validation >> [7]. >> >> The vote will be open for at least 72 hours. It is adopted by majority >> approval, with at least 3 PMC affirmative votes. >> >> Thanks, >> Ahmet >> >> [1] >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343985 >> [2] https://dist.apache.org/repos/dist/dev/beam/2.8.0 >> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS >> [4] >> https://repository.apache.org/content/repositories/orgapachebeam-1049/ >> [5] https://github.com/apache/beam/tree/v2.8.0-RC1 >> [6] https://github.com/apache/beam-site/pull/583 and >> https://github.com/apache/beam/pull/6745 >> [7] >> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1854712816 >> > >
