Can you please fix the conflict in the PR ? Thanks Regards JB
On 03/12/2018 08:52, Chaim Turkel wrote: > it looks like there was a failure that is not due to the code, how can > i continue the process? > https://github.com/apache/beam/pull/7162 > > On Thu, Nov 29, 2018 at 9:15 PM Chaim Turkel <ch...@behalf.com> wrote: >> >> hi, >> i added another pr for the case of a self signed certificate ssl on >> the mongodb server >> >> https://github.com/apache/beam/pull/7162 >> On Wed, Nov 28, 2018 at 5:16 PM Jean-Baptiste Onofré <j...@nanthrax.net> >> wrote: >>> >>> Hi, >>> >>> I already upgraded locally. Let me push the PR. >>> >>> Regards >>> JB >>> >>> On 28/11/2018 16:02, Chaim Turkel wrote: >>>> is there any reason that the mongo client version is still on 3.2.2? >>>> can you upgrade it to 3.9.0? >>>> chaim >>>> On Tue, Nov 27, 2018 at 4:48 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>>> >>>>> Hi Chaim, >>>>> >>>>> The best is to create a Jira describing the new features you want to >>>>> add. Then, you can create a PR related to this Jira. >>>>> >>>>> As I'm the original MongoDbIO author, I would be more than happy to help >>>>> you and review the PR. >>>>> >>>>> Thanks ! >>>>> Regards >>>>> JB >>>>> >>>>> On 27/11/2018 15:37, Chaim Turkel wrote: >>>>>> Hi, >>>>>> I have added a few features to the MongoDbIO and would like to add >>>>>> them to the project. >>>>>> I have read https://beam.apache.org/contribute/ >>>>>> I have added a jira user, what do i need to do next? >>>>>> >>>>>> chaim >>>>>> >>>>> >>>>> -- >>>>> Jean-Baptiste Onofré >>>>> jbono...@apache.org >>>>> http://blog.nanthrax.net >>>>> Talend - http://www.talend.com >>>> >>> >>> -- >>> Jean-Baptiste Onofré >>> jbono...@apache.org >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
