Hi Michael,
Sounds good. We can run a series of tests on the PR to make sure nothing
major breaks.
In the light of the upcoming 2.10.0/2.11.0 release, perhaps we should
target Gradle 5 for 2.12.0?
Thanks,
Max
On 08.02.19 13:55, Ismaël Mejía wrote:
+1 and extra points for unblocking Java 11.
Great work Michael!
On Fri, Feb 8, 2019 at 12:14 PM Michael Luckey <[email protected]> wrote:
Hi,
shortly we implemented changes on the build system to enable upgrade to the
latest gradle 5.
These changes were mostly updates to latest versions of the used gradle
plugins. As of now the upgrade should be a simple version switch and upgrading
to further plugins to versions incompatible with gradle4.
As we also integrated Jacoco coverage reports on Jenkins, see e.g. [1], and
gradle 4 does not support build-cache in conjunction with Jacoco [2], I d
recommend doing the upgrade now.
This will reenable the build cache, i.e. test results will be cacheable again.
FWIW, it will also unlock java11 support on gradle [3] and [4].
Unfortunately I could not execute all tasks on my environment so we might hit
an hidden issue but I do not expect anything serious.
Does anyone have any concerns about that change?
cheers,
michel
[1] https://builds.apache.org/job/beam_PreCommit_Java_Cron/923/jacoco/
[2]
https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L305-L310
[3] https://docs.gradle.org/5.0/release-notes.html
[4] https://gradle.org/whats-new/gradle-5/
