Reverted commit to not block people on this. It should be ok now. Sorry for the noise, I did that commit because it was suggested during the discussion of the PR.
On Fri, Feb 8, 2019 at 11:55 PM Mikhail Gryzykhin <[email protected]> wrote: > > created BEAM-6637 to track this. > > --Mikhail > > Have feedback? > > > On Fri, Feb 8, 2019 at 1:52 PM Mikhail Gryzykhin <[email protected]> wrote: >> >> +Ismael (commit author) explicitly >> >> --Mikhail >> >> Have feedback? >> >> >> On Fri, Feb 8, 2019 at 10:47 AM Michael Luckey <[email protected]> wrote: >>> >>> Hi, >>> >>> currently PRs are failing due to >>> >>> 19:14:30 FAILURE: Build completed with 2 failures. >>> 19:14:30 >>> 19:14:30 1: Task failed with an exception. >>> 19:14:30 ----------- >>> 19:14:30 * What went wrong: >>> 19:14:30 Execution failed for task >>> ':beam-runners-google-cloud-dataflow-java-fn-api-worker:findbugsMain'. >>> 19:14:30 > FindBugs rule violations were found. See the report at: >>> file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/runners/google-cloud-dataflow-java/worker/build/reports/findbugs/main.xml >>> >>> >>> I traced it down to [1]. Which, from commit message is confusing me, >>> because now fund bugs is unhappy. >>> >>> >>> Is it possible to revert? Or something else we should do? >>> >>> >>> Thanks, >>> >>> >>> michel >>> >>> >>> [1] >>> https://github.com/apache/beam/commit/72627eb9f0b556574c23ceea06b3547d96c4107d
