You are right that it was decided that a contributor can review a committer's PR. I think the committer guide was never updated, and we should do so.
On Tue, Mar 12, 2019 at 10:28 AM Gleb Kanterov <[email protected]> wrote: > Before pressing merge button I was familiarizing myself with committer > guide [1]. It's saying: > > > A committer (who is not the author of the code) should signal this > either by GitHub “approval” or by a comment such as “Looks good to me!” > (LGTM). Any committer can then merge the pull request. It is fine for a > committer to self-merge if another committer has reviewed the code and > approved it, just be sure to be explicit about whose job it is! > > As I understand it, it's saying that the reviewer should be Beam > Committer. However, I remember from my personal experience and reading "An > approach to community building from Apache Beam" [2] that > > > either the reviewer or the author be a committer > > I'm wondering if we could rephrase our Commiter Guide a bit to make it > clear. > > [1]: https://beam.apache.org/contribute/committer-guide/ > [2]: > https://blogs.apache.org/comdev/entry/an-approach-to-community-building > >
