Oops. False alarm. Thanks guys : ) Best -P. On Tue, Mar 19, 2019 at 10:53 AM Udi Meiri <[email protected]> wrote:
> At least for python, any changes under runners/ trigger a precommit: > https://github.com/apache/beam/blob/34b071c0b0f08fceb451ce9c4a4bcaab6160abcd/.test-infra/jenkins/job_PreCommit_Python.groovy#L27 > > On Tue, Mar 19, 2019 at 10:38 AM Pablo Estrada <[email protected]> wrote: > >> Perhaps it's just that the rules are more extensive for Java worker >> changes. I noticed that my change runs Go, Python and Java precommits: >> https://github.com/apache/beam/pull/8080 >> >> On Tue, Mar 19, 2019 at 10:27 AM Udi Meiri <[email protected]> wrote: >> >>> Do you have an example PR Pablo? >>> >>> >>> On Mon, Mar 18, 2019, 18:23 Alan Myrvold <[email protected]> wrote: >>> >>>> The includedRegions was set up as part of >>>> https://issues.apache.org/jira/browse/BEAM-4445 and there are >>>> additional paths added from >>>> https://github.com/apache/beam/blob/6bb4b2332b11bd8295ac6965be8426b9c38fa454/.test-infra/jenkins/PrecommitJobBuilder.groovy#L65 >>>> >>>> Not sure why they are not working, but it would be good to get this >>>> going again. Might have stopped at the same time Jenkins was updated. >>>> >>>> On Mon, Mar 18, 2019 at 3:28 PM Pablo Estrada <[email protected]> >>>> wrote: >>>> >>>>> We used to have tests run selectively depending on which directories >>>>> were changes. I've just noticed that this is not the case anymore. >>>>> >>>>> Did we stop doing that? Or maybe the selector is faulty? Anyone know >>>>> what happened here? >>>>> Thanks! >>>>> -P. >>>>> >>>>
