Sorry for the confusion, I checked JIRA but not pull requests. Please consider the vote for RC1 canceled.
I'm going to keep running through all the tests before I cut RC2, so expect that to happen Monday unless there are new issues or pull requests. Andrew On Thu, Apr 4, 2019 at 2:47 AM Ismaël Mejía <ieme...@gmail.com> wrote: > > I suggest keeping the bug open until the cherry-pick is complete. That > makes tracking the burndown easier and is more accurate treatment of Fix > Version. > > Yes, sorry for that mistake, I just systematically resolve issues when > merged so I did as well for those issues instead of waiting until the > cherry pick was merged. > > > I normally wouldn't say anything since this is micro process, but > building an RC can take some time so it is worth putting extra effort into > pre-RC steps. > > My excuses Andrew if the lack of open issues was the reason why you > tagged the branch, sorry for the extra work of creating a new RC > because of this. can we please cut the next RC. > > On Thu, Apr 4, 2019 at 1:11 AM Kenneth Knowles <k...@apache.org> wrote: > > > > I suggest keeping the bug open until the cherry-pick is complete. That > makes tracking the burndown easier and is more accurate treatment of Fix > Version. > > > > And from the other direction, a good practice is to check not only the > Jira burndown [1] and also search for pull requests targeting the release > branch [2]. > > > > I normally wouldn't say anything since this is micro process, but > building an RC can take some time so it is worth putting extra effort into > pre-RC steps. > > > > Kenn > > > > [1] https://issues.apache.org/jira/projects/BEAM/versions/12344944 > > [2] https://github.com/apache/beam/pulls?q=is:open+base:release-2.12.0 > > > > On Wed, Apr 3, 2019 at 12:39 PM Ismaël Mejía <ieme...@gmail.com> wrote: > >> > >> -1 > >> > >> The release misses a cherry pick [1] that fixes an important issue in > >> Cassandra, without this users won't be able to write to Cassandra. I > >> know at least 3 users who are waiting for this release to have this > >> fixed. > >> > >> [1] https://github.com/apache/beam/pull/8198/files > >> > >> On Wed, Apr 3, 2019 at 8:34 PM Andrew Pilloud <apill...@google.com> > wrote: > >> > > >> > Hi everyone, > >> > > >> > Please review and vote on the release candidate #1 for the version > 2.12.0, as follows: > >> > > >> > [ ] +1, Approve the release > >> > [ ] -1, Do not approve the release (please provide specific comments) > >> > > >> > The complete staging area is available for your review, which > includes: > >> > * JIRA release notes [1], > >> > * the official Apache source release to be deployed to > dist.apache.org [2], which is signed with the key with fingerprint > 9E7CEC0661EFD610B632C610AE8FE17F9F8AE3D4 [3], > >> > * all artifacts to be deployed to the Maven Central Repository [4], > >> > * source code tag "v2.12.0-RC1" [5], > >> > * website pull request listing the release [6] and publishing the API > reference manual [7]. > >> > * Python artifacts are deployed along with the source release to the > dist.apache.org [2]. > >> > * Validation sheet with a tab for 2.12.0 release to help with > validation [8]. > >> > > >> > The vote will be open for at least 72 hours. It is adopted by > majority approval, with at least 3 PMC affirmative votes. > >> > > >> > Thanks, > >> > Andrew > >> > > >> > [1] > https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12344944 > >> > [2] https://dist.apache.org/repos/dist/dev/beam/2.12.0/ > >> > [3] https://dist.apache.org/repos/dist/release/beam/KEYS > >> > [4] > https://repository.apache.org/content/repositories/orgapachebeam-1065/ > >> > [5] https://github.com/apache/beam/tree/v2.12.0-RC1 > >> > [6] https://github.com/apache/beam/pull/8215 > >> > [7] https://github.com/apache/beam-site/pull/588 > >> > [8] > https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1007316984 >
