Sure, I will cherry pick those PRs. On Tue, May 28, 2019 at 2:19 PM Kyle Weaver <kcwea...@google.com> wrote:
> Hi Ankur, > > It's not a blocker, but I'd like to see > https://github.com/apache/beam/pull/8558 and > https://github.com/apache/beam/pull/8569 be included so TFX examples can > be run without errors on the 2.13.0 Spark runner ( > https://github.com/tensorflow/tfx/pull/84). > > Kyle Weaver | Software Engineer | github.com/ibzib | kcwea...@google.com > | +16502035555 > > > On Tue, May 28, 2019 at 11:53 AM Ankur Goenka <goe...@google.com> wrote: > >> Thanks for the validation. >> >> I have marked fixed version of >> https://issues.apache.org/jira/browse/BEAM-7406 >> https://issues.apache.org/jira/browse/BEAM-6380 to be 2.13.0 and will >> cherry pick the associated commits to the jira. >> >> >> On Tue, May 28, 2019 at 11:19 AM Lukasz Cwik <lc...@google.com> wrote: >> >>> I would also suggest to get https://github.com/apache/beam/pull/8668 in >>> to 2.13.0 since it fixes a logging setup issue on Dataflow (BEAM-7406). >>> >>> On Tue, May 28, 2019 at 10:22 AM Chamikara Jayalath < >>> chamik...@google.com> wrote: >>> >>>> I would also like to get https://github.com/apache/beam/pull/8661 in >>>> to 2.13.0 that fixes https://issues.apache.org/jira/browse/BEAM-6380. >>>> It's not a new issue but has affected a number of users. >>>> >>>> - Cham >>>> >>>> On Tue, May 28, 2019 at 9:31 AM Valentyn Tymofieiev < >>>> valen...@google.com> wrote: >>>> >>>>> Thanks, Juta Staes, for reporting this issue. >>>>> >>>>> On Tue, May 28, 2019, 9:19 AM Valentyn Tymofieiev <valen...@google.com> >>>>> wrote: >>>>> >>>>>> -1. >>>>>> I would like us to fix >>>>>> https://issues.apache.org/jira/browse/BEAM-7439 for 2.13.0. It is a >>>>>> regression that happened in 2.12.0, but was not caught by existing tests. >>>>>> >>>>>> Thanks, >>>>>> Valentyn >>>>>> >>>>>> On Wed, May 22, 2019, 4:30 PM Ankur Goenka <goe...@google.com> wrote: >>>>>> >>>>>>> Hi everyone, >>>>>>> >>>>>>> Please review and vote on the release candidate #1 for the version >>>>>>> 2.13.0, as follows: >>>>>>> >>>>>>> [ ] +1, Approve the release >>>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>>> >>>>>>> The complete staging area is available for your review, which >>>>>>> includes: >>>>>>> * JIRA release notes [1], >>>>>>> * the official Apache source release to be deployed to >>>>>>> dist.apache.org [2], which is signed with the key with fingerprint >>>>>>> 6356C1A9F089B0FA3DE8753688934A6699985948 [3], >>>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>>>> * source code tag "v2.13.0-RC1" [5], >>>>>>> * website pull request listing the release [6] and publishing the >>>>>>> API reference manual [7]. >>>>>>> * Python artifacts are deployed along with the source release to the >>>>>>> dist.apache.org [2]. >>>>>>> * Validation sheet with a tab for 2.13.0 release to help with >>>>>>> validation [8]. >>>>>>> >>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>>>> majority approval, with at least 3 PMC affirmative votes. >>>>>>> >>>>>>> Thanks, >>>>>>> Ankur >>>>>>> >>>>>>> [1] >>>>>>> https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12345166 >>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.13.0/ >>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>>>> [4] >>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1069/ >>>>>>> [5] https://github.com/apache/beam/tree/v2.13.0-RC1 >>>>>>> [6] https://github.com/apache/beam/pull/8645 >>>>>>> [7] https://github.com/apache/beam-site/pull/589 >>>>>>> [8] >>>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1031196952 >>>>>>> >>>>>>
