We have been currently been having every runner define and manage its own suite/tests so yes modifying flink_runner.gradle is currently the correct thing to do.
There is a larger discussion about whether this is the right way since we would like to capture things like perf benchmarks and validates runner tests so we can add information to the website about how well a feature is supported by each runner automatically. On Thu, Jun 6, 2019 at 8:36 PM Reza Rokni <[email protected]> wrote: > Hi, > > I would like to validate some code that I am building under > extensions against different runners. It makes use of some caches in a DoFn > which are a little off the beaten path. > > I have added @ValidatesRunner to the class and by adding the right values > to the gradle file in flink_runner have got the tests to run. However it > does not feel right for me to change the flink_runner.gradle file to > achieve this, especially as this is all experimental and under extensions. > > I could copy over all the bits needed from the gradle file over to my > extensions gradle, but then I would need to do that for all runners , which > also feels a bit heavy weight. Is there a way, or should there be a way of > having a task added to my gradle file which will do tests against all > runners for me? > > Cheers > Reza > > -- > > This email may be confidential and privileged. If you received this > communication by mistake, please don't forward it to anyone else, please > erase all copies and attachments, and please let me know that it has gone > to the wrong person. > > The above terms reflect a potential business arrangement, are provided > solely as a basis for further discussion, and are not intended to be and do > not constitute a legally binding obligation. No legally binding obligations > will be created, implied, or inferred until an agreement in final form is > executed in writing by all parties involved. >
