+1

Run build and used diffoscope [1] to compare the generated vs staged
files. We should probably in the future make the full gradle build
reproducible to make this comparison trivial (a simple diff).

[1] https://diffoscope.org/

On Tue, Jul 16, 2019 at 2:18 AM Lukasz Cwik <lc...@google.com> wrote:
>
> +1
>
> On Mon, Jul 15, 2019 at 8:14 PM Pablo Estrada <pabl...@google.com> wrote:
>>
>> +1
>> verified hashes and signatures
>>
>> On Fri, Jul 12, 2019 at 9:40 AM Kai Jiang <j...@uber.com> wrote:
>>>
>>> +1 (non-binding)
>>>
>>> On Thu, Jul 11, 2019 at 8:27 PM Lukasz Cwik <lc...@google.com> wrote:
>>>>
>>>> Please review the release of the following artifacts that we vendor:
>>>>  * beam-vendor-grpc_1_21_0
>>>>  * beam-vendor-guava-26_0-jre
>>>>  * beam-vendor-bytebuddy-1_9_3
>>>>
>>>> Hi everyone,
>>>> Please review and vote on the release candidate #3 for the 
>>>> org.apache.beam:beam-vendor-grpc_1_21_0:0.1, 
>>>> org.apache.beam:beam-vendor-guava-26_0-jre:0.1, and 
>>>> org.apache.beam:beam-vendor-bytebuddy-1_9_3:0.1 as follows:
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>
>>>>
>>>> The complete staging area is available for your review, which includes:
>>>> * the official Apache source release to be deployed to dist.apache.org 
>>>> [1], which is signed with the key with fingerprint 
>>>> EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>>>> * all artifacts to be deployed to the Maven Central Repository [3],
>>>> * commit hash "0fce2b88660f52dae638697e1472aa108c982ae6" [4],
>>>>
>>>> The vote will be open for at least 72 hours. It is adopted by majority 
>>>> approval, with at least 3 PMC affirmative votes.
>>>>
>>>> Thanks,
>>>> Luke
>>>>
>>>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>>>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>>>> [3] https://repository.apache.org/content/repositories/orgapachebeam-1078/
>>>> [4] 
>>>> https://github.com/apache/beam/commit/0fce2b88660f52dae638697e1472aa108c982ae6

Reply via email to