+1 for increasing tests on Python3. As we know that Python2 will be officially deprecated EOF 2019, we should put more focus on Python3 coverage in order to support features/components in the long term. Replicating existing Python2 tests configurations should be straightforward and will help to unveil Python3 issues as early as possible.
Thanks, Mark On Fri, Aug 2, 2019 at 1:43 PM Valentyn Tymofieiev <[email protected]> wrote: > Thank you, Mark. > > Everyone, if you have recently added, or are planning to add, a Python SDK > test suite, please make sure to replicate this suite to run under at least > one Python 3 minor version to make sure use cases work on Python 3. If you > pick only one Python 3 minor version (to save resources and time to run the > tests, when adding other 3.x suites won't add significant coverage), I > recommend picking Python 3.5 as newer versions are backwards-compatible. > > Feel free to reach out to this thread if you have any questions about how > to make your test suite run in Python 3. > > Thank you, > Valentyn > > On Fri, Aug 2, 2019 at 9:36 PM Mark Liu <[email protected]> wrote: > >> Hi all, >> >> Some refactors are made recently on Python Gradle configurations to unify >> tests among Py2 and Py3x. More specifically, Py2 tests defined in >> sdks/python/build.gradle >> <https://github.com/apache/beam/blob/master/sdks/python/build.gradle> were >> moved to sdks/python/test-suites >> <https://github.com/apache/beam/tree/master/sdks/python/test-suites> >> under subdirectories corresponding to runner/type + py version. >> >> After the movement, Py2 tests are located under: >> test-suites/dataflow/py2 >> test-suites/direct/py2 >> test-suites/portable/py2 >> test-suites/tox/py2 >> >> <https://github.com/apache/beam/blob/master/sdks/python/build.gradle> >> sdks/python/build.gradle >> <https://github.com/apache/beam/blob/master/sdks/python/build.gradle> >> become much simpler and will hold basic builds/analysis tasks for Python >> SDK in general. >> >> This is related to early discussions in this thread >> <https://lists.apache.org/thread.html/7c48200678c570c6e42d4933f8ea4f9324d82f7ae720b591a93ffcda@%3Cdev.beam.apache.org%3E> >> @dev >> and aim to avoid confusion on test configuration and divergent between Py2 >> and Py3 testing. And potentially help to reduce code duplication in Gradle. >> >> Thanks, >> Mark >> >
