Your proposal will only affect the seed job (which doesn't do color outputs AFAIK). I think you want to add colorizeOutput() here: https://github.com/apache/beam/blob/bfebbd0d16361f61fa40bfdec2f0cb6f943f7c9a/.test-infra/jenkins/CommonJobProperties.groovy#L79-L95
Otherwise no concerns from me. On Tue, Oct 22, 2019 at 12:01 PM Chad Dombrova <[email protected]> wrote: > thanks, so IIUC, I’m going to update job_00_seed.groovy like this: > > wrappers { > colorizeOutput() > timeout { > absolute(60) > abortBuild() > } > } > > Then add the comment run seed job > > Does anyone have any concerns with me trying this out now? > > -chad > > On Tue, Oct 22, 2019 at 11:42 AM Udi Meiri <[email protected]> wrote: > >> Also note that changing the job DSL doesn't take effect until the "seed" >> job runs. (use the "run seed job" phrase) >> >> On Tue, Oct 22, 2019 at 11:06 AM Chad Dombrova <[email protected]> wrote: >> >>> Thanks, I'll look into this. I have a PR I'm building up with a handful >>> of minor changes related to this. >>> >>> >>> >>> On Tue, Oct 22, 2019 at 10:45 AM Yifan Zou <[email protected]> wrote: >>> >>>> Thanks, Udi! The ansicolor plugin was applied to ASF Jenkins >>>> universally. You might need to explicitly enable the coloroutput in your >>>> jenkins dsl. >>>> >>>> On Tue, Oct 22, 2019 at 10:33 AM Udi Meiri <[email protected]> wrote: >>>> >>>>> Seems to be already installed: >>>>> https://issues.apache.org/jira/browse/INFRA-16944 >>>>> Do we just need to enable it somehow? >>>>> This might work: >>>>> https://jenkinsci.github.io/job-dsl-plugin/#method/javaposse.jobdsl.dsl.helpers.wrapper.WrapperContext.colorizeOutput >>>>> >>>>> BTW, our Jenkins is maintained by ASF's Infrastructure team: >>>>> https://cwiki.apache.org/confluence/display/INFRA/Jenkins >>>>> >>>>> On Tue, Oct 22, 2019 at 10:23 AM Chad Dombrova <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi all, >>>>>> As a user trying to grok failures in jenkins I think it would be a >>>>>> huge help to have color output support. This is something that works out >>>>>> of the box for CI tools like gitlab and travis, and it really helps bring >>>>>> that 21st century feel to your logs :) >>>>>> >>>>>> There's a Jenkins plugin for colorizing ansi escape sequences here: >>>>>> https://plugins.jenkins.io/ansicolor >>>>>> >>>>>> I think this is something that has to be deployed by a Jenkins admin. >>>>>> >>>>>> -chad >>>>>> >>>>>>
smime.p7s
Description: S/MIME Cryptographic Signature
