I think that implicitly (and forcefully) pull the remote image is not good even in case of a bug fix. The better approach would be releasing a separate bug fix version. Implicitly pulling the updated version of the same container looks weird to me since it feels like releasing the jar artifact with the same version multiple times or publishing already published git branch again. However, I understand it's much easier to just update the container with the same tag than release another Beam version.
On Wed, Nov 6, 2019 at 8:05 AM Valentyn Tymofieiev <valen...@google.com> wrote: > I agree with the resolutions in the link Thomas mentioned [1]. Using > latest tag is not reliable, and a unique tag ID should be generated when > running tests on Jenkins against master branch. > I think pulling the latest image for the current tag is actually a desired > behavior, in case the external image was updated (due to a bug fix for > example). Our custom container documentation should reflect this behavior. > Consider continuing the conversation in [1] to keep it in one place if > there are other suggestions/opinions. > > [1] > https://lists.apache.org/thread.html/07131e314e229ec60100eaa2c0cf6dfc206bf2b0f78c3cee9ebb0bda@%3Cdev.beam.apache.org%3E > > > On Fri, Nov 1, 2019 at 5:14 PM Thomas Weise <t...@apache.org> wrote: > >> More here: >> https://lists.apache.org/thread.html/07131e314e229ec60100eaa2c0cf6dfc206bf2b0f78c3cee9ebb0bda@%3Cdev.beam.apache.org%3E >> >> >> On Fri, Nov 1, 2019 at 10:56 AM Chamikara Jayalath <chamik...@google.com> >> wrote: >> >>> I think it makes sense to override published docker images with locally >>> built versions when testing HEAD. >>> >>> Thanks, >>> Cham >>> >>> On Thu, Oct 31, 2019 at 6:31 PM Heejong Lee <heej...@google.com> wrote: >>> >>>> Hi, happy halloween! >>>> >>>> I'm looking into failing cross language post commit tests: >>>> https://issues.apache.org/jira/browse/BEAM-8534 >>>> <https://issues.apache.org/jira/browse/BEAM-8534?filter=-1> >>>> >>>> After a few runs, I've found that published SDK harness containers >>>> overwrite locally built containers when docker pull happens. I can think of >>>> two possible solutions here: 1) remove the published images with the latest >>>> tag, so make the image with the latest tag available for testing and >>>> development purposes. 2) put serialVersionUID to the class printing out the >>>> error. >>>> >>>> 2) doesn't sound like a fundamental solution if we're not going to >>>> attach serialVersionUID to all serializable classes. 1) might work but I'm >>>> not sure whether there's another use for the latest tag somewhere. Any >>>> better ideas? >>>> >>>> Thanks, >>>> Heejong >>>> >>>
