Update: I'm accepting cherrypicks with failing tests if the corresponding PR have passed them on master.
I recall (without proof) that in the past, even with released worker containers for the in-process release, that ITs against the release branch still fail. On Tue, Dec 10, 2019 at 10:58 AM Udi Meiri <eh...@google.com> wrote: > Re: cherrypicks on top of the release-2.18.0 branch > The precommit tests are failing most likely due to some integration tests > (wordcount, etc.) that are expecting the new 2.18 worker on Dataflow. > I'm working on building an initial version of that worker so that the > tests may pass. > > On Thu, Dec 5, 2019 at 4:39 PM Robert Bradshaw <rober...@google.com> > wrote: > >> Yeah, so I saw... >> >> On Thu, Dec 5, 2019 at 4:31 PM Udi Meiri <eh...@google.com> wrote: >> > >> > Sorry Robert the release was already cut yesterday. >> > >> > >> > >> > On Thu, Dec 5, 2019 at 8:37 AM Ismaël Mejía <ieme...@gmail.com> wrote: >> >> >> >> Colm, I just merged your PR and cherry picked it into 2.18.0 >> >> https://github.com/apache/beam/pull/10296 >> >> >> >> On Thu, Dec 5, 2019 at 10:54 AM jincheng sun <sunjincheng...@gmail.com> >> wrote: >> >>> >> >>> Thanks for the Tracking Udi! >> >>> >> >>> I have updated the status of some release blockers issues as follows: >> >>> >> >>> - BEAM-8733 closed >> >>> - BEAM-8620 reset the fix version to 2.19 >> >>> - BEAM-8618 reset the fix version to 2.19 >> >>> >> >>> Best, >> >>> Jincheng >> >>> >> >>> Colm O hEigeartaigh <cohei...@apache.org> 于2019年12月5日周四 下午5:38写道: >> >>>> >> >>>> Could we get this one in 2.18 as well? >> https://issues.apache.org/jira/browse/BEAM-8861 >> >>>> >> >>>> Colm. >> >>>> >> >>>> On Wed, Dec 4, 2019 at 8:02 PM Udi Meiri <eh...@google.com> wrote: >> >>>>> >> >>>>> Following the release calendar, I plan on cutting the 2.18 release >> branch today. >> >>>>> >> >>>>> There are currently 8 release blockers. >> >>>>> >> >
smime.p7s
Description: S/MIME Cryptographic Signature