I am fine with adding this as a linter. I would not want to block either (let alone both) until we have some experience with them. Hopefully, if our code is clean and correctly typed, it should pass both. Where it doesn't, I'm hopeful that the looseness provided by gradual typing will allow us to have reasonable workarounds. But I think all we can do is speculate until we have more data.
On Tue, Jan 7, 2020 at 7:02 PM Udi Meiri <[email protected]> wrote: > Hi, > We recently added mypy to the Jenkins Lint job for PRs (currently ignores > errors). Mypy is a static type checker. > > There's a JIRA for adding another static type checker named pytype > https://issues.apache.org/jira/browse/BEAM-9064 > > I wanted to ask the community their thoughts on this. (see JIRA issue > comments as well) > > - Should PRs have to pass more than 1 static type checker? (in pre-commit > tests) > - If not, should the remaining type checkers be run as a post-commit tests? > - How much effort should be put into supporting more than 1 type checker? > (i.e. making sure that they all pass) > > > >
