I verified python 2 quickstarts with batch and streaming pipelines, wheel files, and reviewed changes to the blog/website.
Udi, could you send an updated version of the voting text with TODOs, template pieces removed? We can discuss changes to the template separately. My vote is +1 pending an updated vote text. On Tue, Jan 14, 2020 at 4:47 PM Udi Meiri <[email protected]> wrote: > Sorry about the messiness. > The links at the bottom should be correct though. > > I intentionally did not replace MAVEN_VERSION because I didn't know how to > get it (I didn't execute mvn for the release). > As for JDK_VERSION, do we still need that? (If so, what about Python > versions, such as the ones used for testing?) > javac -version on my machine is 1.8.0_181-google-v7 > I believe we can drop MAVEN_VERSION now that it is no longer used. I do not think it is needed to add a Gradle version either because the version itself is part of the repo anyway. I do not know if java, python etc. versions are helpful. Maybe others can comment. I would prefer to reduce the load on the release manager and drop this if this is not particularly important. > > > On Mon, Jan 13, 2020 at 7:37 PM Valentyn Tymofieiev <[email protected]> > wrote: > >> There are some issues in this message, part of the message is still a >> template (1.2.3, TODO, MAVEN_VERSION). >> Before I noticed these issues, I ran a few Batch and Streaming Python 3.7 >> pipelines using Direct and Dataflow runners, and they all succeeded. >> >> On Mon, Jan 13, 2020 at 4:09 PM Udi Meiri <[email protected]> wrote: >> >>> Hi everyone, >>> Please review and vote on the release candidate #3 for the version >>> 1.2.3, as follows: >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> The complete staging area is available for your review, which includes: >>> * JIRA release notes [1], >>> * the official Apache source release to be deployed to dist.apache.org >>> [2], which is signed with the key with fingerprint 8961 F3EF 8E79 6688 4067 >>> 87CF 587B 049C 36DA AFE6 [3], >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> * source code tag "v1.2.3-RC3" [5], >>> >> Tag is "v2.18.0-RC1". This is correct in the referenced link. > * website pull request listing the release [6], publishing the API >>> reference manual [7], and the blog post [8]. >>> * Java artifacts were built with Maven MAVEN_VERSION and OpenJDK/Oracle >>> JDK JDK_VERSION. >>> TODO: do these versions matter, and are they stamped into the artifacts? >>> * Python artifacts are deployed along with the source release to the >>> dist.apache.org [2]. >>> * Validation sheet with a tab for 2.18.0 release to help with validation >>> [9]. >>> * Docker images published to Docker Hub [10]. >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> approval, with at least 3 PMC affirmative votes. >>> >>> Thanks, >>> Release Manager >>> >>> [1] >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12346383&projectId=12319527 >>> [2] https://dist.apache.org/repos/dist/dev/beam/2.18.0/ >>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>> [4] >>> https://repository.apache.org/content/repositories/orgapachebeam-1090/ >>> [5] https://github.com/apache/beam/tree/v2.18.0-RC1 >>> [6] https://github.com/apache/beam/pull/10574 >>> [7] https://github.com/apache/beam-site/pull/595 >>> [8] https://github.com/apache/beam/pull/10575 >>> [9] >>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1178617819 >>> [10] https://hub.docker.com/u/apachebeam >>> >>
