What prevents the usage of the newer version of Guava?

On Mon, Feb 10, 2020 at 2:28 PM Esun Kim <[email protected]> wrote:

> Hi Beam Developers,
>
> I'm working on pr/10769 <https://github.com/apache/beam/pull/10769> which
> upgrades gcsio from 1.9.16 to 2.0.0 which is an intermediate step to get us
> to use gcsio 2.x which supports gRPC, which potentially gives us better
> performance. (FYI, gcsio is a driver for Google Cloud Storage.)
>
> Link-check was run over this PR (result
> <https://gist.github.com/veblush/a9470a977ed8dfa2f3e94f4c9f3957c7>) and
> it appears that it has a couple of linker warnings from following modules
> because this uses a newer version of guava.
>
>    - com.google.cloud.hadoop.gcsio.cooplock.CoopLockRecordsDao
>    (gcsio-2.0.0.jar)
>    - com.google.cloud.hadoop.gcsio.cooplock.CoopLockOperationDao
>    (gcsio-2.0.0.jar)
>    - com.google.cloud.hadoop.gcsio.testing.InMemoryObjectEntry
>    (gcsio-2.0.0.jar)
>
> But I believe that none of these is not actually problematic because
> cooplock is only for Hadoop (not for Beam) and testing is just testing. So
> I think it's okay to get this merged but I want to get an opinion on this
> from you.
>
> Regards,
> Esun.
>
>

Reply via email to