I will review again, hopefully soon. On Wed, Feb 19, 2020 at 1:44 AM Alex Van Boxel <[email protected]> wrote:
> Hi all, > > can someone give me a LGTM for the DynamicMessage protobuf schema support. > We've been testing this internally on Dataflow and Direct runner and it > works. > > https://github.com/apache/beam/pull/10502 > > It uses the same ProtoDomain to get descriptors serialized in the graph > (as it's needed for going back from Row to Proto). > > I like to make it for the 2.20. Don't mind the failed test as it's again a > flaky test that fails. Thanks. > > _/ > _/ Alex Van Boxel >
