I've assigned it too you. If you create a PR you can add me as reviewer. _/ _/ Alex Van Boxel
On Sat, Feb 22, 2020 at 9:14 AM Jozef Vilcek <[email protected]> wrote: > I have filed https://issues.apache.org/jira/browse/BEAM-9360 for this. > > Seems like I am not able to self assign this, can I get rights to do that > or get someone assign JIRA to me please? > > On Sat, Feb 22, 2020 at 2:41 AM Reuven Lax <[email protected]> wrote: > >> I think that it's incorrect - we shouldn't enforce that the metadata >> match. >> >> On Fri, Feb 21, 2020 at 10:38 AM Jozef Vilcek <[email protected]> >> wrote: >> >>> Hi, >>> >>> I am playing with Schemas in Beam and conversion between types. I am >>> experimenting with Convert transform to convert PCollection of POJOs to >>> Protobufs, but get a failure about schemas not being compatible. >>> >>> The root cause is that FieldType are not passing `equivalent()` check >>> because of difference in metadata as protobuf add there a proto_number >>> >>> https://github.com/apache/beam/blob/v2.19.0/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java#L818 >>> >>> Is it correct that metadata should be strictly equal to pass field type >>> equivalence check, or not? >>> >>> Thanks, >>> Jozef >>> >>
