Iirc we chose to put it in precommit so that it would block adding new dependencies without a license. Maybe we can look into caching as a way to mitigate run time and flakes?
On Wed, Apr 15, 2020 at 6:16 PM Udi Meiri <[email protected]> wrote: > If this process is used in releases we would benefit from running it > regularly to ensure it isn't broken and thus delay releases (and add work > for the release manager). > Does it make sense to put it in postcommit? > > On Wed, Apr 15, 2020 at 2:30 PM Kyle Weaver <[email protected]> wrote: > >> Looks like the same error as this Jira: >> https://issues.apache.org/jira/browse/BEAM-9764 >> >> Even if/when we are able to fix this particular issue, I agree it is best >> not to run this job except for releases because of the inherent network >> cost and possible reliability issues. +Hannah Jiang >> <[email protected]> What do you think? >> >> On Wed, Apr 15, 2020 at 5:20 PM Thomas Weise <[email protected]> wrote: >> >>> The new feature to assemble licenses is very useful but appears to add >>> several minutes (7-8?) build time to jobs that need to build a container. >>> >>> Does it also seem to cause occasional build failures? >>> >>> >>> https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Phrase/131/ >>> >>> Would it be possible to perform this task only during release builds? >>> >>> Thanks, >>> Thomas >>> >>>
