Hi,

I am curious why grpc_netty is still a compile dependency
since grpc_netty_shaded has been added? I thought the latter would replace
the former, wouldn't it?

Pozdrawiam,
Jacek Laskowski
----
https://about.me/JacekLaskowski
"The Internals Of" Online Books <https://books.japila.pl/>
Follow me on https://twitter.com/jaceklaskowski

<https://twitter.com/jaceklaskowski>


On Sat, May 23, 2020 at 12:29 AM <bhule...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> bhulette pushed a commit to branch release-2.22.0
> in repository https://gitbox.apache.org/repos/asf/beam.git
>
>
> The following commit(s) were added to refs/heads/release-2.22.0 by this
> push:
>      new c3e6b13  [BEAM-8889][release-2.22.0] Upgrades gcsio to 2.1.3
> (#11778)
> c3e6b13 is described below
>
> commit c3e6b1374f40df6199309ad7cb58814b20645080
> Author: Esun Kim <vebl...@google.com>
> AuthorDate: Fri May 22 15:29:23 2020 -0700
>
>     [BEAM-8889][release-2.22.0] Upgrades gcsio to 2.1.3 (#11778)
>
>     * Upgrades gcsio to 2.1.3
>
>     * Add grpc-alts and grpc-netty-shaded explicitly
> ---
>  .../src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy    | 4
> +++-
>  sdks/java/io/google-cloud-platform/build.gradle                       | 2
> ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git
> a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
> b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
> index eaf79fb..0adb35c 100644
> ---
> a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
> +++
> b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
> @@ -382,7 +382,7 @@ class BeamModulePlugin implements Plugin<Project> {
>      def generated_grpc_ga_version = "1.85.1"
>      def google_auth_version = "0.19.0"
>      def google_clients_version = "1.30.9"
> -    def google_cloud_bigdataoss_version = "2.1.2"
> +    def google_cloud_bigdataoss_version = "2.1.3"
>      def google_cloud_core_version = "1.92.2"
>      def google_cloud_spanner_version = "1.49.1"
>      def google_cloud_datacatalog_version = "0.32.1"
> @@ -481,6 +481,7 @@ class BeamModulePlugin implements Plugin<Project> {
>          google_oauth_client                         :
> "com.google.oauth-client:google-oauth-client:$google_oauth_clients_version",
>          google_oauth_client_java6                   :
> "com.google.oauth-client:google-oauth-client-java6:$google_oauth_clients_version",
>          grpc_all                                    :
> "io.grpc:grpc-all:$grpc_version",
> +        grpc_alts                                   :
> "io.grpc:grpc-alts:$grpc_version",
>          grpc_auth                                   :
> "io.grpc:grpc-auth:$grpc_version",
>          grpc_core                                   :
> "io.grpc:grpc-core:$grpc_version",
>          grpc_context                                :
> "io.grpc:grpc-context:$grpc_version",
> @@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin<Project> {
>          grpc_protobuf                               :
> "io.grpc:grpc-protobuf:$grpc_version",
>          grpc_protobuf_lite                          :
> "io.grpc:grpc-protobuf-lite:$grpc_version",
>          grpc_netty                                  :
> "io.grpc:grpc-netty:$grpc_version",
> +        grpc_netty_shaded                           :
> "io.grpc:grpc-netty-shaded:$grpc_version",
>          grpc_stub                                   :
> "io.grpc:grpc-stub:$grpc_version",
>          guava                                       :
> "com.google.guava:guava:$guava_version",
>          guava_testlib                               :
> "com.google.guava:guava-testlib:$guava_version",
> diff --git a/sdks/java/io/google-cloud-platform/build.gradle
> b/sdks/java/io/google-cloud-platform/build.gradle
> index 4424795..d49cd8e 100644
> --- a/sdks/java/io/google-cloud-platform/build.gradle
> +++ b/sdks/java/io/google-cloud-platform/build.gradle
> @@ -56,11 +56,13 @@ dependencies {
>    compile library.java.google_http_client
>    compile library.java.google_http_client_jackson2
>    compile library.java.grpc_all
> +  compile library.java.grpc_alts
>    compile library.java.grpc_auth
>    compile library.java.grpc_core
>    compile library.java.grpc_context
>    compile library.java.grpc_grpclb
>    compile library.java.grpc_netty
> +  compile library.java.grpc_netty_shaded
>    compile library.java.grpc_stub
>    compile library.java.grpc_google_cloud_pubsub_v1
>    compile library.java.guava
>
>

Reply via email to