I also added you to contributors list in Beam Jira and assigned this task to you. Welcome!
> On 14 Aug 2020, at 17:48, Alexey Romanenko <[email protected]> wrote: > > Hi Dennis, > > Thank you for your contribution! > > On 14 Aug 2020, at 16:52, Dennis Yung <[email protected] > <mailto:[email protected]>> wrote: >> >> Shall I apply the change to master and then create a PR? > > Yes, please do you changes against master because all that we merge (except > cherry-pick commits) will be merged into master branch. > >> However I just changed the ver1 aws module but not the ver2 one, > > It would be great if you will apply this patch against AWS SDK v2 module as > well since we are going to deprecate v1 module soon and finally remove it and > keep only v2 module. > >> plus I haven't submitted a PR before so may need some guidance (I have read >> the contribution guide though). > > You need to fork Beam GitHub repository, clone it into your local repo, > create a branch related to your Jira issue, do your changes there and then > push your brach to your remote GitHub repository. Then, from GitHub UI create > a PR to Beam repository. > You can find details with related commands here [1]. Also, ptal on our Beam > Contribution Guide [2] > > Please, don’t hesitate to ask if you need any help with that. > > [1] https://cwiki.apache.org/confluence/display/BEAM/Git+Tips > <https://cwiki.apache.org/confluence/display/BEAM/Git+Tips> > [2] https://beam.apache.org/contribute/ <https://beam.apache.org/contribute/> >
